Skip to content

Fix block placement handler#839

Open
Thodor12 wants to merge 1 commit into
version/mainfrom
feature/fix_block_placement
Open

Fix block placement handler#839
Thodor12 wants to merge 1 commit into
version/mainfrom
feature/fix_block_placement

Conversation

@Thodor12
Copy link
Copy Markdown
Contributor

Closes #812

Changes proposed in this pull request

  • Use the BlockItem#place method similar logic instead of custom placement logic

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@MotionlessTrain
Copy link
Copy Markdown
Contributor

Could you double check whether anything changed regarding torches which were standing on the block?
Just in case they first managed to stand, but now pop off

@Thodor12
Copy link
Copy Markdown
Contributor Author

This is only used during block replacement

@MotionlessTrain
Copy link
Copy Markdown
Contributor

Yeah, that is what I am talking about
When using this to replace a wall of your building with a lower tier material (when designing a lower level building), it would be annoying to pick up all torches that fell inside, and put them back at the right place
Iirc Structurize has support for that (no pun intended), and I was wondering whether that was this code

@Thodor12
Copy link
Copy Markdown
Contributor Author

Oh yeah that'll still be broken but that's impossible to fix because we have to give a block update unfortunately

@MotionlessTrain
Copy link
Copy Markdown
Contributor

As long as that doesn’t get worse than it is now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scan tool replaced the "base" panel variant, rather than the variant selected when replacing trap doors

2 participants