[Feature] Add MoreHorizIcon#1457
Merged
Rajesh-Nagarajan-11 merged 1 commit intolayer5io:masterfrom Apr 30, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the MoreHorizIcon component, including its unit tests and necessary exports. The review feedback suggests improving the SVG's accessibility by dynamically setting the role and aria-hidden attributes based on the presence of a title, and moving the viewBox attribute after the props spread to prevent it from being accidentally overridden.
Signed-off-by: thechillbasu <basusarthakmain@gmail.com>
thechillbasu
force-pushed
the
feature/add-more-horiz-icon-1444
branch
from
b9592a9 to
af3df03
Compare
kishore08-07
approved these changes
Apr 30, 2026
Contributor
kishore08-07
left a comment
kishore08-07
left a comment
There was a problem hiding this comment.
Thanks @thechillbasu , LGTM @Rajesh-Nagarajan-11
Contributor
Author
My pleasure! @kishore08-07 |
Rajesh-Nagarajan-11
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #1444
Adds a new
MoreHorizIconSVG component to the Sistent icon library. This icon represents a horizontal ellipsis for overflow menus and is based on the Material UIMoreHorizicon design. The addition reduces dependency on@mui/icons-materialand ensures design consistency across Layer5 products.Changes made:
src/icons/MoreHoriz/MoreHorizIcon.tsx— NewMoreHorizIconSVG component usingDEFAULT_FILL_NONE,DEFAULT_WIDTH,DEFAULT_HEIGHT, andtitleprop for accessibilitysrc/icons/MoreHoriz/index.ts— Barrel export for the MoreHoriz icon directorysrc/icons/index.ts— RegisteredMoreHorizIconin the icon library's main exportsSigned commits