Skip to content

test: fix flaky canIterateEvents test caused by PipedInputStream timing #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kinyoklion merged 1 commit into from
Jun 9, 2026
+5 −5
Merged

test: fix flaky canIterateEvents test caused by PipedInputStream timing #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/test/java/com/launchdarkly/eventsource/EventSourceReadingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,16 +303,16 @@ public void canIterateEvents() throws Exception {
}
}).start();

StreamEvent e1 = queue.poll(1, TimeUnit.SECONDS);
StreamEvent e1 = queue.poll(5, TimeUnit.SECONDS);
assertThat(e1, equalTo(new StartedEvent()));

StreamEvent e2 = queue.poll(1, TimeUnit.SECONDS);
StreamEvent e2 = queue.poll(5, TimeUnit.SECONDS);
assertThat(e2, equalTo(new MessageEvent("a", "data1", null, ORIGIN)));

StreamEvent e3 = queue.poll(1, TimeUnit.SECONDS);
StreamEvent e3 = queue.poll(5, TimeUnit.SECONDS);
assertThat(e3, equalTo(new CommentEvent("nice")));

StreamEvent e4 = queue.poll(1, TimeUnit.SECONDS);
StreamEvent e4 = queue.poll(5, TimeUnit.SECONDS);
assertThat(e4, equalTo(new MessageEvent("b", "data2", null, ORIGIN)));

assertThat("iterator should not have finished yet because we didn't close the stream",
Expand All @@ -321,7 +321,7 @@ public void canIterateEvents() throws Exception {
stream.close();

assertThat("timed out waiting for iterator on reader thread to finish",
iteratorFinished.tryAcquire(1, TimeUnit.SECONDS), is(true));
iteratorFinished.tryAcquire(5, TimeUnit.SECONDS), is(true));
}

@Test
Expand Down
Loading