Skip to content

fix: Bump embedded commons-codec to 1.23.0 - #263

Merged
tanderson-ld merged 1 commit into
mainfrom
tanderson/issue-262/commons-codec-1.23.0
Nov 16, 2026
Merged

tanderson-ld merged 1 commit into
mainfrom
tanderson/issue-262/commons-codec-1.23.0

Conversation

@tanderson-ld

@tanderson-ld tanderson-ld commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

No new functionality; the existing unit tests exercise every code path that uses this dependency (hashing for bucketing, big segments, and secure mode), and CI validates all supported platforms.

Related issues

Fixes #262

Describe the solution you've provided

Bumps the commons-codec version embedded in the shaded launchdarkly-java-server-sdk jar from 1.19.0 to 1.23.0. The 1.19.0 copy is flagged by dependency scanners for CVE-2026-119078 (critical, CVSS 9.1).

Notes on risk:

  • The CVE affects only the Blake3 class (its Javadoc KDF example derives identical keys because doFinalize is stateless; 1.23.0 ships the corrected documentation). The SDK uses only DigestUtils (SHA-1/SHA-256) and Hex encoding, never Blake3, so the SDK was not exploitable. The bump removes the scanner finding on the embedded copy.
  • None of the behavior changes between 1.19.0 and 1.23.0 (ASCII-only Hex decoding, stricter Base32/Base64 STRICT decoding, Sha2Crypt bounds, QuotedPrintable CRLF handling) are on code paths the SDK uses.
  • commons-codec 1.23.0 keeps the Java 8 source/target baseline.
  • The embedded copy is shaded under com.launchdarkly.shaded and absent from the published pom, so applications never interact with it directly.

Verified locally: the full unit test suite passes (including bucketing tests that assert exact SHA-1-derived values), the packaging jar-contents and pom checks pass, and the reproduction command from #262 now reports version=1.23.0:

$ unzip -p launchdarkly-java-server-sdk-7.18.0.jar META-INF/maven/commons-codec/commons-codec/pom.properties
version=1.23.0

Describe alternatives you've considered

None; this is the fix requested in #262 and the dependency is current as of this PR (1.23.0 is the latest release).

Additional context

N/A


Note

Overview
Bumps the commons-codec version in lib/sdk/server/build.gradle from 1.19.0 to 1.23.0, so the shaded launchdarkly-java-server-sdk uberjar embeds the newer library and clears dependency-scanner findings (e.g. CVE-2026-119078 on the packaged copy).

This is a build-only dependency pin change; SDK runtime behavior for existing DigestUtils / Hex usage is unchanged.

Reviewed by Cursor Bugbot for commit da82f59. Bugbot is set up for automated code reviews on this repo. Configure here.

The shaded launchdarkly-java-server-sdk jar embedded commons-codec
1.19.0, which dependency scanners flag for CVE-2026-119078. The SDK
only uses DigestUtils and Hex encoding and never the affected Blake3
class, so it was not exploitable, but bumping to 1.23.0 clears the
finding.

Fixes #262
@tanderson-ld
tanderson-ld requested a review from a team as a code owner November 16, 2026 14:27

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: Low.

Automated risk review (dry run): Low

This PR would be automatically approved.

Why: The only change is a one-line commons-codec pin in lib/sdk/server/build.gradle (1.19.0 to 1.23.0) with no SDK source, CI, or policy edits. Cursor Bugbot passed with no findings, and existing hashing/encoding tests cover the DigestUtils and Hex call sites.

If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.

Open in Web View Automation 

Sent by Cursor Approval Agent: Dry-Run PR Approver

@cursor cursor Bot added the risk:low label Nov 16, 2026
@tanderson-ld
tanderson-ld merged commit be5f5c5 into main Nov 16, 2026
33 checks passed
@tanderson-ld
tanderson-ld deleted the tanderson/issue-262/commons-codec-1.23.0 branch November 16, 2026 14:47
tanderson-ld pushed a commit that referenced this pull request Nov 16, 2026
🤖 I have created a release *beep* *boop*
---


##
[7.18.1](launchdarkly-java-server-sdk-7.18.0...launchdarkly-java-server-sdk-7.18.1)
(2026-11-16)


### Bug Fixes

* Bump embedded commons-codec to 1.23.0
([#263](#263))
([be5f5c5](be5f5c5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Overview**
> Cuts a **7.18.1** patch release for `lib/sdk/server`, aligning Release
Please metadata and the runtime version string consumers see.
> 
> Version markers move from **7.18.0** to **7.18.1** in
`.release-please-manifest.json`, `gradle.properties`, and
`Version.SDK_VERSION`, and `CHANGELOG.md` documents the release as a bug
fix that **bumps embedded commons-codec to 1.23.0** ([#263]).
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
fcc516f. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump embedded commons-codec to 1.23.0 to address CVE-2026-119078

2 participants