Repository navigation
fix: Bump embedded commons-codec to 1.23.0 - #263
Merged
Merged
Conversation
The shaded launchdarkly-java-server-sdk jar embedded commons-codec 1.19.0, which dependency scanners flag for CVE-2026-119078. The SDK only uses DigestUtils and Hex encoding and never the affected Blake3 class, so it was not exploitable, but bumping to 1.23.0 clears the finding. Fixes #262
There was a problem hiding this comment.
Risk: Low.
Automated risk review (dry run): Low
This PR would be automatically approved.
Why: The only change is a one-line commons-codec pin in lib/sdk/server/build.gradle (1.19.0 to 1.23.0) with no SDK source, CI, or policy edits. Cursor Bugbot passed with no findings, and existing hashing/encoding tests cover the DigestUtils and Hex call sites.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
jsonbailey
approved these changes
Nov 16, 2026
tanderson-ld
pushed a commit
that referenced
this pull request
Nov 16, 2026
🤖 I have created a release *beep* *boop* --- ## [7.18.1](launchdarkly-java-server-sdk-7.18.0...launchdarkly-java-server-sdk-7.18.1) (2026-11-16) ### Bug Fixes * Bump embedded commons-codec to 1.23.0 ([#263](#263)) ([be5f5c5](be5f5c5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Overview** > Cuts a **7.18.1** patch release for `lib/sdk/server`, aligning Release Please metadata and the runtime version string consumers see. > > Version markers move from **7.18.0** to **7.18.1** in `.release-please-manifest.json`, `gradle.properties`, and `Version.SDK_VERSION`, and `CHANGELOG.md` documents the release as a bug fix that **bumps embedded commons-codec to 1.23.0** ([#263]). > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit fcc516f. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requirements
No new functionality; the existing unit tests exercise every code path that uses this dependency (hashing for bucketing, big segments, and secure mode), and CI validates all supported platforms.
Related issues
Fixes #262
Describe the solution you've provided
Bumps the commons-codec version embedded in the shaded
launchdarkly-java-server-sdkjar from 1.19.0 to 1.23.0. The 1.19.0 copy is flagged by dependency scanners for CVE-2026-119078 (critical, CVSS 9.1).Notes on risk:
Blake3class (its Javadoc KDF example derives identical keys becausedoFinalizeis stateless; 1.23.0 ships the corrected documentation). The SDK uses onlyDigestUtils(SHA-1/SHA-256) andHexencoding, never Blake3, so the SDK was not exploitable. The bump removes the scanner finding on the embedded copy.Hexdecoding, stricter Base32/Base64 STRICT decoding, Sha2Crypt bounds, QuotedPrintable CRLF handling) are on code paths the SDK uses.com.launchdarkly.shadedand absent from the published pom, so applications never interact with it directly.Verified locally: the full unit test suite passes (including bucketing tests that assert exact SHA-1-derived values), the packaging jar-contents and pom checks pass, and the reproduction command from #262 now reports
version=1.23.0:Describe alternatives you've considered
None; this is the fix requested in #262 and the dependency is current as of this PR (1.23.0 is the latest release).
Additional context
N/A
Note
Overview
Bumps the commons-codec version in
lib/sdk/server/build.gradlefrom 1.19.0 to 1.23.0, so the shadedlaunchdarkly-java-server-sdkuberjar embeds the newer library and clears dependency-scanner findings (e.g. CVE-2026-119078 on the packaged copy).This is a build-only dependency pin change; SDK runtime behavior for existing
DigestUtils/Hexusage is unchanged.Reviewed by Cursor Bugbot for commit da82f59. Bugbot is set up for automated code reviews on this repo. Configure here.