Repository navigation
fix: Accept selectorless FDv2 full payloads - #372
Draft
kinyoklion wants to merge 1 commit into
Draft
kinyoklion wants to merge 1 commit into
kinyoklion wants to merge 1 commit into
Conversation
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
launchdarkly/ld-relay#979 serves FDv2 full transfers that have no selector:
server-intentwithid:""andtarget:0, followed bypayload-transferred {"state":"","version":0}.protocol_handler.dartdropped that event with "Ignoring payload-transferred with missing fields", so the SDK never applied the data. The contract test is launchdarkly/sdk-test-harness#600.Describe the solution you've provided
protocol_handler.dart: accepts an emptystateandversion0 as a full payload with no selector, and emitsSelector.empty. That clears any held selector, and later requests omitbasis.protocol_types.dart: keeps a missingstateas null so malformed events are still rejected.Selector.emptycorrectly. An initializer's data without a selector continues the init chain and becomes ready when the chain is exhausted. A synchronizer full payload without a selector becomes ready immediately.state, and orchestrator regressions for initializer continuation, synchronizer readiness and clearing the selector.Describe alternatives you've considered
None. Dropping the payload leaves the SDK uninitialized behind Relay when Relay has no selector.
Additional context
common_clientformat, analyze and tests pass (651 tests).Link to Devin session: https://app.devin.ai/sessions/f3b22e19bdde48f1b39f77808077390b
Open in Devin Desktop: https://app.devin.ai/desktop/session/f3b22e19bdde48f1b39f77808077390b?variant=devin
Requested by: @kinyoklion
SDK-3593