Repository navigation
feat: Add eventSource to LDConfig #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+33
−3
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b1be5c7
feat: Add eventSourceFactory to LDConfig
joker23 7bb6b91
fix: Export the SSE event types from the Flutter SDK
joker23 1c5690b
fix: Remove the SSE event type exports and clarify the eventSourceFac…
joker23 f36933e
refactor: Replace eventSourceFactory with useHttpStreamingOnWeb
joker23 1d3d489
chore: Keep the example app to basic usage
joker23 8526fda
refactor: Replace useHttpStreamingOnWeb on LDConfig with an eventSour…
joker23 80ad41b
docs: State that eventSource on LDConfig must supply a client that ca…
joker23 6be783a
chore: Update launchdarkly_common_client to version 1.16.0
joker23 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
packages/flutter_client_sdk/test/ld_config_streaming_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import 'package:flutter_test/flutter_test.dart'; | ||
| import 'package:launchdarkly_flutter_client_sdk/launchdarkly_flutter_client_sdk.dart'; | ||
|
|
||
| void main() { | ||
| test('eventSource is null by default', () { | ||
| final config = LDConfig('credential', AutoEnvAttributes.disabled); | ||
|
|
||
| expect(config.eventSource, isNull); | ||
| }); | ||
|
|
||
| test('eventSource is stored in the configuration', () { | ||
| final config = LDConfig('credential', AutoEnvAttributes.disabled, | ||
| eventSource: SSEClient.http); | ||
|
|
||
| expect(config.eventSource, same(SSEClient.http)); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.