Brent pla 1693 more logging and v3.9.0 - #193
Closed
jareddellitt wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 0ed3fc1. Configure here.
| _ -> | ||
| ok | ||
| end, | ||
| erlang:send_after(1000, self(), {check_shotgun_state}), |
There was a problem hiding this comment.
Shotgun poll message mismatch
Medium Severity
The Shotgun health poll schedules its next tick with {check_shotgun_state} while handle_info only handles the atom check_shotgun_state. After the first poll (~1s after connect), later messages no longer match those clauses and are dropped by the generic handle_info, so the new “silent failure” polling never continues.
Reviewed by Cursor Bugbot for commit 0ed3fc1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Describe the solution you've provided
Add additional logging and updated otp version
Note
Medium Risk
Changes touch the live streaming reconnect path and may log SSE FIN payloads; CI-only OTP addition is low risk but expands the compatibility surface.
Overview
Adds OTP 28.4.1 (with matching rebar) to the GitHub Actions build matrix so the SDK is tested on the newest supported Erlang.
In
ldclient_update_stream_server, observability around the LaunchDarkly SSE/Shotgun path is expanded: the process sets logger metadata on init, logs when a Shotgun connection is established, and starts a 1scheck_shotgun_statepoll that warns if Shotgun is{down, _}before the client’sDOWNhandling kicks in (with an info log when there is no connection to poll). SSEfincallbacks now log the ignored payload via?LOG_INFObefore closing and reconnecting.Reviewed by Cursor Bugbot for commit 0ed3fc1. Bugbot is set up for automated code reviews on this repo. Configure here.