Skip to content

Brent pla 1693 more logging and v3.9.0 - #193

Closed
jareddellitt wants to merge 2 commits into
launchdarkly:mainfrom
knocklabs:brent-pla-1693-more-logging-and-v3.9.0
Closed

Brent pla 1693 more logging and v3.9.0#193
jareddellitt wants to merge 2 commits into
launchdarkly:mainfrom
knocklabs:brent-pla-1693-more-logging-and-v3.9.0

Conversation

@jareddellitt

@jareddellitt jareddellitt commented Jul 21, 2026

Copy link
Copy Markdown

Describe the solution you've provided
Add additional logging and updated otp version


Note

Medium Risk
Changes touch the live streaming reconnect path and may log SSE FIN payloads; CI-only OTP addition is low risk but expands the compatibility surface.

Overview
Adds OTP 28.4.1 (with matching rebar) to the GitHub Actions build matrix so the SDK is tested on the newest supported Erlang.

In ldclient_update_stream_server, observability around the LaunchDarkly SSE/Shotgun path is expanded: the process sets logger metadata on init, logs when a Shotgun connection is established, and starts a 1s check_shotgun_state poll that warns if Shotgun is {down, _} before the client’s DOWN handling kicks in (with an info log when there is no connection to poll). SSE fin callbacks now log the ignored payload via ?LOG_INFO before closing and reconnecting.

Reviewed by Cursor Bugbot for commit 0ed3fc1. Bugbot is set up for automated code reviews on this repo. Configure here.

@jareddellitt
jareddellitt requested a review from a team as a code owner July 21, 2026 21:46

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 0ed3fc1. Configure here.

_ ->
ok
end,
erlang:send_after(1000, self(), {check_shotgun_state}),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shotgun poll message mismatch

Medium Severity

The Shotgun health poll schedules its next tick with {check_shotgun_state} while handle_info only handles the atom check_shotgun_state. After the first poll (~1s after connect), later messages no longer match those clauses and are dropped by the generic handle_info, so the new “silent failure” polling never continues.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0ed3fc1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants