chore: migrate to launch-workflows 0.14.2#4
Open
bryce-lynn-nttd wants to merge 5 commits into
Open
Conversation
|
Caution Auto-labeling failed, likely due to a misconfiguration in the The auto-labeler workflow was allowed to complete successfully because you have a configuration change to Please manually apply the appropriate label ( |
AWS provider 6 is reconciling the role's inline policy into aws_iam_role state, which leaves the separate aws_iam_role_policy resource drifting after apply. This moves the policy ownership onto aws_iam_role so the module stays idempotent under the sync-workflows test run.
The sync-workflows PR now gets through apply, but the post-deploy test reads CodePipeline immediately and intermittently gets a nil response before the control plane is fully consistent. This adds a bounded retry around GetPipeline so the test waits for the pipeline to become readable instead of failing on a transient empty response.
The post-deploy retry logic now reaches AWS consistently, but forcing WithSharedConfigProfile(AWS_PROFILE) causes the SDK to fall back to profile-based credential resolution in GitHub Actions and fail against IMDS. This removes the explicit shared profile override so the test uses the ambient OIDC credentials configured by the workflow, which matches the working AWS test pattern used elsewhere in the repo set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
launch-workflowsreusable workflows at version0.14.2actions-lcafworkflow filesrelease-drafter.ymlanddependabot.ymlFiles changed
A .github/dependabot.ymlA .github/release-drafter.ymlD .github/workflows/increment-tagged-version.yamlD .github/workflows/lint-terraform.yamlA .github/workflows/pull-request-label.ymlA .github/workflows/pull-request-terraform-check-aws.ymlA .github/workflows/release-publish.ymlD .github/workflows/validate-branch-name.yamlM .tool-versionsM MakefileGenerated by
sync_workflows.pyfrom launch-workflows