fix(runtime): skip default retries for unsafe methods#77
Merged
Conversation
Signed-off-by: samzong <samzong.lu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #16.
MaxRetries > 0as the opt-in path for callers that intentionally want retries on other methods.POSTrequests are not retried after a retryable status.Verification
go test ./pkg/runtime -run 'TestHTTPClient_DefaultRetriesSkipPost|TestRetryTransport'go test ./pkg/runtimego test -race ./pkg/runtimemake check/pre-ship --committedmanual gate: no MUST-FIX findings; sentinel writtenCompatibility
Generated mutating commands no longer retry by default on 429/5xx. Safe methods keep default retries, and callers can still opt into retrying other methods by setting
MaxRetries > 0. No generated command shape, catalog schema, auth, body, output, or generated code changes.Checklist
internal/generated/,.cache/, and ad-hocskills/<cli-name>/directories is not committed.