Skip to content

Add support for deleting securities #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marty-macfly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for deleting securities #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 16 additions & 17 deletions finary_uapi/user_securities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,9 @@ def add_imported_securities_to_account(
found = True
break
if not found:
if dry_run:
logging.info(f'-- Delete {account_security["security"]["name"]}')
logging.info(f'-- Delete {account_security["security"]["name"]}')
if not dry_run:
delete_user_security(session, account_security["id"])

for line in to_be_imported:
# search by ISIN in the account
Expand All @@ -181,11 +182,11 @@ def add_imported_securities_to_account(
line["quantity"] != account_security["quantity"]
or line["price"] != account_security["display_buying_price"]
):
if dry_run:
logging.info(
f'** Update [{security["name"]}]: {account_security["quantity"]} -> {line["quantity"]} - [{account_security["display_buying_price"]} -> {line["price"]}]' # noqa
)
else:

logging.info(
f'** Update [{security["name"]}]: {account_security["quantity"]} -> {line["quantity"]} - [{account_security["display_buying_price"]} -> {line["price"]}]' # noqa
)
if not dry_run:
update_user_security(
session,
account_security,
Expand All @@ -196,11 +197,10 @@ def add_imported_securities_to_account(
found = True
break
if not found:
if dry_run:
logging.info(
f'++ Add [{security["symbol"]}]: {line["quantity"]} - {line["price"]}' # noqa
)
else:
logging.info(
f'++ Add [{security["symbol"]}]: {line["quantity"]} - {line["price"]}' # noqa
)
if not dry_run:
add_user_security(
session,
account["id"],
Expand All @@ -209,11 +209,10 @@ def add_imported_securities_to_account(
line["price"],
)
else:
if dry_run:
logging.info(
f'+ Add [{security["symbol"]}]: {line["quantity"]} - {line["price"]}'
)
else:
logging.info(
f'+ Add [{security["symbol"]}]: {line["quantity"]} - {line["price"]}'
)
if not dry_run:
add_user_security(
session,
account["id"],
Expand Down