Skip to content

Improvements to curvilinear TRT - #11

Open
pdmullen wants to merge 6 commits into
mainfrom
pdmullen/curv-transport
Open

Improvements to curvilinear TRT#11
pdmullen wants to merge 6 commits into
mainfrom
pdmullen/curv-transport

Conversation

@pdmullen

@pdmullen pdmullen commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

PR Summary

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the scripts/format.sh command or by using @par-hermes format
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • LANL employees: make sure tests pass both on the github CI and on the re-git CI
  • If ML was used, make sure to add a disclaimer at the top of a file indicating ML was used to assist in generating the file.
  • If Agentic AI was used, have the AI generate a "proposed changes" markdown file and store it in the plan_histories folder, with a filename the same as the MR number.

If preparing for a new release, in addition please check the following:

  • Update the version in cmake.

@pdmullen pdmullen changed the title Improvements to curvilinear TRT WIP: Improvements to curvilinear TRT Sep 2, 2026
Comment on lines +100 to +103
//! \fn void LatLonGrid::ApplyFiniteVolumeCorrections
//! \brief Replace the cell-centered normal directions with their exact solid-angle
//! averages <n_i> = (1/dOmega) int n_i dOmega for the finite-volume transport speeds;
//! cart_pos_unit retains the true centroid unit vectors (if needed).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pdmullen pdmullen changed the title WIP: Improvements to curvilinear TRT Improvements to curvilinear TRT Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants