Skip to content

added surf_qpt_qpt_map.set_values(-1) in geometry.h - #59

Merged
nathanielmorgan merged 1 commit into
mainfrom
ref_surf
Aug 21, 2026
Merged

nathanielmorgan merged 1 commit into
mainfrom
ref_surf

Conversation

@nathanielmorgan

Copy link
Copy Markdown
Collaborator

Description

Quick patch to initialize surf_qpt_qpt_map.set_values(-1); inside geometry.h file, ensuring ease of use when building quadrature point connectivity on the surface. It's not a bug, but I'll mark it as such since users are unlikely to know they must initialize the array to -1.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A : DG remap test

Test Configuration:

  • OS version: Mac
  • Hardware: M2
  • Compiler: clang

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jacob-moore22
jacob-moore22 self-requested a review August 21, 2026 20:24

@jacob-moore22 jacob-moore22 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nathanielmorgan
nathanielmorgan merged commit a5abe09 into main Aug 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants