added surf_qpt_qpt_map.set_values(-1) in geometry.h - #59
Merged
Merged
Conversation
jacob-moore22
self-requested a review
August 21, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Quick patch to initialize surf_qpt_qpt_map.set_values(-1); inside geometry.h file, ensuring ease of use when building quadrature point connectivity on the surface. It's not a bug, but I'll mark it as such since users are unlikely to know they must initialize the array to -1.
Type of change
Please select all relevant options
How Has This Been Tested?
Test Configuration:
Checklist: