Repository navigation
Expose head message Sender for private-answer replies - #2
Merged
alessioc42 merged 1 commit intoOct 27, 2026
Merged
Conversation
The server routes a reply only by its "to" value. Replies in a privateAnswerOnly conversation must be addressed to the head message's Sender (as the web client's read.js does), otherwise they are visible to every participant. Parse Sender into Conversation.sender so clients can do that. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The server routes a conversation reply only by the
tovalue. The website'smodule/nachrichten/js/read.jsaddresses replies in aprivateAnswerOnlyconversation ("Mitteilung") to the head message'sSenderwhen the user isn't its author. Clients sendingto: "all"make the reply visible to every participant.Change
Senderinto a new optionalConversation.sender.replyToConversationdocs to explain why"all"is wrong for these replies.The app-side fix that uses this field is in a companion PR on lanis-mobile/lanis.
Not compiled or tested locally; no Dart/Flutter toolchain was available.
🤖 Generated with Claude Code