fix(api): add missing admin and RBAC permission decorators to OAuth custom-client GET endpoint - #40979
Closed
FasihUrRahman wants to merge 1 commit into
Closed
Conversation
…ustom-client GET endpoint Add @is_admin_or_owner_required and @rbac_permission_required decorators to ToolOAuthCustomClient.get in api/controllers/console/workspace/tool_providers.py. This aligns the GET method with the POST and DELETE handlers on the same route, ensuring normal workspace members without CREDENTIAL_MANAGE permissions cannot retrieve sensitive OAuth client credentials. Closes langgenius#40944
dosubot
Bot
added
the
size:XS
Member
|
Duplicated |
Contributor
Pyrefly Type Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #40944
Add missing
@is_admin_or_owner_requiredand@rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)decorators to the GET endpoint:ToolOAuthCustomClient.getinapi/controllers/console/workspace/tool_providers.pyMotivation & Impact
The
POSTandDELETEhandlers ofToolOAuthCustomClientalready enforce that only workspace admins/owners or members with theCREDENTIAL_MANAGERBAC permission can manage OAuth custom clients. However, theGETendpoint was missing these decorators, allowing normal workspace members to retrieve sensitive OAuth client secrets.Adding these decorators protects the endpoint and aligns the read handler with the write and delete operations.