fix(api): add missing admin and RBAC permission decorators to model credentials GET endpoints - #40962
Merged
asukaminato0721 merged 1 commit intoAug 20, 2026
Conversation
…redentials GET endpoints Add @is_admin_or_owner_required and @rbac_permission_required decorators to: - ModelProviderCredentialApi.get (api/controllers/console/workspace/model_providers.py) - ModelProviderModelCredentialApi.get (api/controllers/console/workspace/models.py) This matches sibling POST/PUT/DELETE endpoints and ensures normal members without CREDENTIAL_MANAGE permissions cannot view raw workspace model provider credentials. Closes langgenius#40899
dosubot
Bot
added
the
size:XS
Contributor
Pyrefly Type Coverage
|
asukaminato0721
enabled auto-merge
August 19, 2026 08:27
asukaminato0721
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #40899
Add missing
@is_admin_or_owner_requiredand@rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)decorators to the following GET endpoints:ModelProviderCredentialApi.getinapi/controllers/console/workspace/model_providers.pyModelProviderModelCredentialApi.getinapi/controllers/console/workspace/models.pyMotivation & Impact
The corresponding
post,put, anddeleteendpoints for model and provider credentials enforce that only workspace admins/owners or members with theCREDENTIAL_MANAGERBAC permission can manage credentials. However, thegetendpoints were missing these decorators, allowing non-admin members to retrieve configured credentials.Adding these decorators aligns the read endpoints with their write counterparts and prevents unauthorized access to model credentials.