feat(workflow): expose bulk execution status as a system variable - #40955
Open
lxy123hh wants to merge 2 commits into
Open
feat(workflow): expose bulk execution status as a system variable#40955lxy123hh wants to merge 2 commits into
lxy123hh wants to merge 2 commits into
Conversation
lxy123hh
requested review from
QuantumGhost,
crazywoola,
iamjoel,
laipz8200 and
zxhlyh
as code owners
August 19, 2026 01:38
Member
|
Please attach some screenshots as well. |
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-08-19 03:25:35.817129645 +0000
+++ /tmp/pyrefly_pr.txt 2026-08-19 03:25:22.501914818 +0000
@@ -3491,7 +3491,7 @@
ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole` in function `models.model.UploadFile.__init__` [bad-argument-type]
--> tests/unit_tests/controllers/console/datasets/test_datasets_segments.py:1208:29
ERROR Object of class `FunctionType` has no attribute `assert_called_once_with` [missing-attribute]
- --> tests/unit_tests/controllers/console/explore/test_trial.py:199:5
+ --> tests/unit_tests/controllers/console/explore/test_trial.py:207:5
ERROR Argument `() -> Session` is not assignable to parameter `session_factory` with type `sessionmaker[@_]` in function `sqlalchemy.orm.scoping.scoped_session.__init__` [bad-argument-type]
--> tests/unit_tests/controllers/console/explore/test_wraps.py:28:39
ERROR Argument `str` is not assignable to parameter `view` with type `(InstalledApp) -> str` in function `controllers.console.explore.wraps.decorator` [bad-argument-type]
@@ -3897,7 +3897,7 @@
ERROR Missing argument `message_id` in function `controllers.common.controller_schemas.SavedMessageCreatePayload.__init__` [missing-argument]
--> tests/unit_tests/controllers/web/test_pydantic_models.py:308:38
ERROR Missing argument `inputs` in function `controllers.common.controller_schemas.WorkflowRunPayload.__init__` [missing-argument]
- --> tests/unit_tests/controllers/web/test_pydantic_models.py:329:31
+ --> tests/unit_tests/controllers/web/test_pydantic_models.py:334:31
ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
--> tests/unit_tests/controllers/web/test_web_forgot_password.py:30:9
ERROR `None` is not subscriptable [unsupported-operation]
@@ -5069,13 +5069,13 @@
ERROR Cannot index into `str` [bad-index]
--> tests/unit_tests/core/app/apps/test_streaming_utils.py:128:12
ERROR Argument `tuple[Literal['layer']]` is not assignable to parameter `graph_engine_layers` with type `Sequence[GraphEngineLayer]` in function `core.app.apps.workflow.app_generator.WorkflowAppGenerator.resume` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:323:29
+ --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:325:29
ERROR Argument `tuple[Literal['base-layer']]` is not assignable to parameter `graph_engine_layers` with type `Sequence[GraphEngineLayer]` in function `core.app.apps.workflow.app_generator.WorkflowAppGenerator._generate` [bad-argument-type]
- --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:407:33
+ --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:409:33
ERROR Cannot index into `object` [bad-index]
- --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:416:27
+ --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:418:27
ERROR Cannot index into `object` [bad-index]
- --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:419:12
+ --> tests/unit_tests/core/app/apps/test_workflow_app_generator.py:421:12
ERROR Argument `SimpleNamespace` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
--> tests/unit_tests/core/app/apps/test_workflow_app_runner_core.py:72:55
ERROR Argument `SimpleNamespace` is not assignable to parameter `queue_manager` with type `AppQueueManager` in function `core.app.apps.workflow_app_runner.WorkflowBasedAppRunner.__init__` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
Author
Thanks for the feedback. I've added a screenshot showing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fixes #<issue number>.Summary
sys.is_bulk_executionvariable for top-level Workflow runsfalsefor existing clients while allowing Service API callers to set it explicitlysys.batchvariable unchangedFixes #40021
Screenshots
Checklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint gods