refactor(api): extract web app runtime bootstrap - #40949
Merged
Merged
Conversation
Contributor
Pyrefly Diffbase → PR--- /tmp/pyrefly_base.txt 2026-08-20 04:31:41.439133234 +0000
+++ /tmp/pyrefly_pr.txt 2026-08-20 04:31:26.880976095 +0000
@@ -630,8 +630,6 @@
--> tests/integration_tests/workflow/test_response_stream_filter_integration.py:75:37
ERROR Argument `core.workflow.nodes.human_input.entities.HumanInputNodeData` is not assignable to parameter `data` with type `graphon.nodes.human_input.entities.HumanInputNodeData` in function `graphon.nodes.human_input.human_input_node.HumanInputNode.__init__` [bad-argument-type]
--> tests/integration_tests/workflow/test_response_stream_filter_pause_resume_integration.py:113:14
-ERROR Argument `Literal['image']` is not assignable to parameter `value` with type `IconType | SQLCoreOperations[IconType | None] | None` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
- --> tests/test_containers_integration_tests/controllers/web/test_site.py:116:26
ERROR Argument `SimpleNamespace` is not assignable to parameter `webapp_settings` with type `WebAppSettings | None` in function `controllers.web.wraps._validate_user_accessibility` [bad-argument-type]
--> tests/test_containers_integration_tests/controllers/web/test_wraps.py:78:33
ERROR Argument `SimpleNamespace` is not assignable to parameter `webapp_settings` with type `WebAppSettings | None` in function `controllers.web.wraps._validate_user_accessibility` [bad-argument-type]
@@ -3771,7 +3769,7 @@
ERROR Returned type `AppDatabase` is not assignable to declared return type `Iterator[AppDatabase]` [bad-return]
--> tests/unit_tests/controllers/service_api/app/test_app.py:154:12
ERROR Object of class `FromClause` has no attribute `delete` [missing-attribute]
- --> tests/unit_tests/controllers/service_api/app/test_app.py:366:29
+ --> tests/unit_tests/controllers/service_api/app/test_app.py:367:29
ERROR Cannot index into `Iterable[bytes]` [bad-index]
--> tests/unit_tests/controllers/service_api/app/test_audio.py:191:16
ERROR Cannot index into `Response` [bad-index]
@@ -8715,7 +8713,7 @@
ERROR `not in` is not supported between `None` and `str` [unsupported-operation]
--> tests/unit_tests/services/test_feedback_service.py:166:16
ERROR Argument `Literal['invalid']` is not assignable to parameter `session_factory` with type `Engine | sessionmaker[Unknown] | None` in function `services.file_service.FileService.__init__` [bad-argument-type]
- --> tests/unit_tests/services/test_file_service.py:75:41
+ --> tests/unit_tests/services/test_file_service.py:76:41
ERROR Unexpected keyword argument `whole_workspace` in function `core.workflow.human_input_adapter.EmailRecipients.__init__` [unexpected-keyword]
--> tests/unit_tests/services/test_human_input_delivery_test_service.py:250:44
ERROR Argument `list[FromClause]` is not assignable to parameter `tables` with type `Sequence[Table] | None` in function `sqlalchemy.sql.schema.MetaData.create_all` [bad-argument-type]
|
Contributor
Pyrefly Type Coverage
|
41tair
reviewed
Aug 19, 2026
hjlarry
force-pushed
the
refactor/web-app-site
branch
from
August 19, 2026 07:59
843e155 to
8f30988
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40949 +/- ##
=======================================
Coverage 86.81% 86.82%
=======================================
Files 5198 5199 +1
Lines 291566 291642 +76
Branches 58089 58093 +4
=======================================
+ Hits 253130 253210 +80
+ Misses 33449 33444 -5
- Partials 4987 4988 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
41tair
reviewed
Aug 19, 2026
hjlarry
force-pushed
the
refactor/web-app-site
branch
from
August 20, 2026 04:30
4ac0be6 to
6eb329f
Compare
41tair
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Web /site controller currently performs ORM reads and then calls feature and file infrastructure from the request path. This change gives those responsibilities explicit owners while reusing the existing App Definition database adapter instead of adding an endpoint-specific repository.
Compatibility
Stack: follows #40795.