fix(api): enforce admin and RBAC permissions on tool OAuth custom client GET endpoint (#40944) - #40945
Merged
asukaminato0721 merged 1 commit intoAug 20, 2026
Conversation
agarwalpranav0711
requested review from
QuantumGhost and
laipz8200
as code owners
August 18, 2026 17:23
Contributor
Pyrefly Type Coverage
|
agarwalpranav0711
force-pushed
the
fix/tool-oauth-custom-client-permission-check
branch
from
August 19, 2026 17:26
17a7a0c to
e7a95cc
Compare
Member
|
Please update to the latest origin/main and fix the CI errors. |
asukaminato0721
enabled auto-merge
August 20, 2026 09:09
asukaminato0721
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #40944
The
GET /console/api/workspaces/current/tool-provider/builtin/<provider>/oauth/custom-clientendpoint inToolOAuthCustomClientwas missing authorization decorators:@is_admin_or_owner_required@rbac_permission_required(RBACResourceScope.WORKSPACE, RBACPermission.CREDENTIAL_MANAGE, resource_required=False)This allowed workspace members without admin/owner roles or credential management RBAC permissions to fetch custom OAuth client configuration details.
Added missing permission decorators to match sibling
postanddeletemethods and added corresponding unit test assertion.Screenshots
N/A (Backend API permission enforcement)
Checklist
make lint && make type-check(backend) andvp staged(frontend) to appease the lint gods