Skip to content

fix(web): prevent signin page content from overflowing on mobile - #40921

Merged
crazywoola merged 1 commit into
langgenius:mainfrom
gegemeimingzi:fix/signin-css-overflow
Aug 21, 2026
Merged

fix(web): prevent signin page content from overflowing on mobile#40921
crazywoola merged 1 commit into
langgenius:mainfrom
gegemeimingzi:fix/signin-css-overflow

Conversation

@gegemeimingzi

Copy link
Copy Markdown
Contributor

Summary

Fixes #35606

The signin page buttons and text overflow their container on narrow
mobile viewports. Two root causes:

  1. The card container uses shrink-0 which prevents it from ever
    shrinking below its content width — replaced with min-w-0.
  2. The form wrapper has md:w-100 but no width on smaller screens.
    Since the parent uses items-center (prevents stretching), child
    elements with w-full have no proper constraint — added w-full
    so it fills the padded container on mobile.
  3. Bonus: fixed w-hull typo (→ w-full) in both normal-form.tsx
    and webapp-signin/normalForm.tsx.

Changes

  • web/app/signin/layout.tsxshrink-0min-w-0, add w-full
    to inner wrapper
  • web/app/signin/normal-form.tsxw-hullw-full
  • web/app/(shareLayout)/webapp-signin/normalForm.tsx — same typo fix

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • tsc --noEmit passes
  • lint-staged passes
  • Visual verification requires running the app on a narrow viewport

- Replace `shrink-0` with `min-w-0` on the card container so it can
  shrink below its content width on narrow viewports
- Add `w-full` to the form wrapper so child elements with `w-full`
  have a proper width constraint on mobile (md:w-100 only applies at md+)
- Fix `w-hull` typo → `w-full` in both signin normalForm files

Fixes langgenius#35606
@gegemeimingzi
gegemeimingzi requested a review from iamjoel as a code owner August 18, 2026 04:41
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 18, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 18, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 21, 2026
@crazywoola
crazywoola enabled auto-merge August 21, 2026 10:31
@crazywoola
crazywoola added this pull request to the merge queue Aug 21, 2026
Merged via the queue into langgenius:main with commit 7d5c68c Aug 21, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

css is awesome

2 participants