Skip to content

fix(web): match IPv6 loopback hostname with brackets in isPrivateOrLo… #40152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zl86790 wants to merge 6 commits into
base: main
Choose a base branch
from
+9 −2
Open

fix(web): match IPv6 loopback hostname with brackets in isPrivateOrLo… #40152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8785e63
fix(web): match IPv6 loopback hostname with brackets in isPrivateOrLo…
zl86790 Aug 7, 2026
acb9e1d
Merge branch 'main' into fix/ipv6-loopback-hostname-bracket-mismatch
zl86790 Aug 7, 2026
9cff18c
Merge branch 'main' into fix/ipv6-loopback-hostname-bracket-mismatch
zl86790 Aug 7, 2026
a836440
Merge branch 'main' into fix/ipv6-loopback-hostname-bracket-mismatch
zl86790 Aug 8, 2026
3b50c81
Merge branch 'main' into fix/ipv6-loopback-hostname-bracket-mismatch
zl86790 Aug 8, 2026
af50f1a
Merge branch 'main' into fix/ipv6-loopback-hostname-bracket-mismatch
zl86790 Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion web/utils/urlValidation.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { validateRedirectUrl } from './urlValidation'
import { isPrivateOrLocalAddress, validateRedirectUrl } from './urlValidation'

describe('URL Validation', () => {
describe('validateRedirectUrl', () => {
Expand Down Expand Up @@ -56,4 +56,11 @@ describe('URL Validation', () => {
expect(() => validateRedirectUrl('//example.com')).toThrow('Invalid URL')
})
})

describe('isPrivateOrLocalAddress', () => {
it('should recognize the IPv6 loopback address', () => {
expect(isPrivateOrLocalAddress('http://[::1]/')).toBe(true)
expect(isPrivateOrLocalAddress('http://[::1]:8080/')).toBe(true)
})
})
})
2 changes: 1 addition & 1 deletion web/utils/urlValidation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function isPrivateOrLocalAddress(url: string): boolean {
const hostname = urlObj.hostname.toLowerCase()

// Check for localhost
if (hostname === 'localhost' || hostname === '127.0.0.1' || hostname === '::1') return true
if (hostname === 'localhost' || hostname === '127.0.0.1' || hostname === '[::1]') return true

// Check for private IP ranges
const ipv4Regex = /^(\d+)\.(\d+)\.(\d+)\.(\d+)$/
Expand Down