Move the inline tests out of seven pinned tally/ files

[lamemustafa]

Next batch of smaller pinned files, all in src-tauri/src/tally/. Editing any of their inline tests re-hashed a production file, so each test module moves to a sibling <stem>_tests.rs loaded with #[cfg(test)] #[path = "..."] mod tests;. The new files stay unpinned (#416).

file	moved #[test]s	compiled when
standard_ledger_catalog.rs	4	default
serial_queue.rs	4	default
outstandings_runtime.rs	8	7 with voucher-scan, all 8 with live-calibration-harness
capability_packs.rs	5	default
validators.rs	5	default
agent_read_request.rs	1	default
approved_import.rs	1	default

What was checked

• No code change. Re-indenting each new file and putting it back rebuilds the old file byte for byte. rustfmt then re-wrapped lines in standard_ledger_catalog_tests.rs and agent_read_request_tests.rs. String literals and non-whitespace tokens are unchanged, and none of the parents changed.
• Same tests. cargo test -p bridge --lib -- --list output is identical under default, voucher-scan, live-calibration-harness and lab-writes (968, 986, 988 and 1068). The moved tests pass by exact name: 20 under default and lab-writes, 27 under voucher-scan, 28 under live-calibration-harness.
• Tree-reading gates, run after the reseal: cargo test -p bridge-tally-compatibility and cargo test -p bridge --test admission_and_egress_files_stay_pinned (approved_import.rs is still pinned there). Both pass.
• Clippy as CI runs it: bridge --lib --tests, the portable crates, and the protocol feature set.
• Scripts: request-builder hazards (pinned 10), live-read boundary (capability_packs.rs is one of its production surfaces and still passes), workflow consistency, unbounded reads, parser-test symmetry, PII regex coverage, fixture byte integrity.
• corepack pnpm test passes (239 node, 113 vitest, 10 Playwright). On the first run, the known trial-balance-screen.test.tsx export flake failed again; the rerun was clean.
• scripts/reseal.sh --verify passes. The surface diff changes exactly the 7 parents' hashes, and the coverage report shows exactly 7 newly unsealed test-only modules.
• Text readers: scripts/ux1-shell.test.mjs reads agent_read_request.rs, but only to compare its bytes with the surface hash, which the reseal updates. The pnpm run above covers it.

Left out: tally/tdl_engine.rs

Once its tests are extracted, check-tally-request-builder-hazards.mjs scans tdl_engine_tests.rs as production and reports two new entries: the $$NumItems:BRIDGE Group/Ledger Collection V1 strings that exact_report_collection_is_shared_by_count_and_rows asserts on. This is the latent false alarm #443 was closed over. Moving these tests needs either a pinned-set entry for a test function or a scanner change, and both change the gate, so the file stays as it is.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.