Skip to content

Move the inline tests out of tally/runtime.rs and tally/connection.rs #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamemustafa merged 2 commits into from
Sep 16, 2026
Merged

Move the inline tests out of tally/runtime.rs and tally/connection.rs #440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8ccbe4
Move the inline tests out of tally/runtime.rs and tally/connection.rs
lamemustafa Sep 16, 2026
72afa57
Point the outstandings evidence test at where the runtime's tests now…
lamemustafa Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/tally/compatibility/compatibility-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"schema_version": 1,
"bridge_commit_sha": "be1c20cc3fd66fa1ece196505c69f26e555e4b8e",
"compatibility_surface_sha256": "368223b42559082724513067a7133a94fa4983fdb110ecb18fb57c45b44d51b3",
"compatibility_surface_sha256": "d1f7d3d265c7bda1f97b03db15220fd8de9d195cfd7cf34c0466e879cd580db6",
"claims": [
{
"claim_id": "erp9-6-6-3-windows-education-xml-one-company",
Expand Down
6 changes: 3 additions & 3 deletions docs/tally/compatibility/compatibility-surface.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@
},
{
"path": "src-tauri/src/tally/connection.rs",
"sha256": "76abe63f9b2e8b1fdea9b8b98d818d5e03195f0c50fcfb67d0d6b8fc01e7059b"
"sha256": "b09660a80abafdf50f9e64323dec62a4004109f2bc8b8ea959b8544ce8832ab5"
},
{
"path": "src-tauri/src/tally/connector.rs",
Expand All @@ -747,7 +747,7 @@
},
{
"path": "src-tauri/src/tally/runtime.rs",
"sha256": "9f1e388637760ddb0aa5c4de884c9f9dbc66e5714ace4cdd6bdbd2949888a81b"
"sha256": "dd8794f1bdb1fbb2b66b21c53e53fe2823ff2a29b00b59ccf1ef2748c58f0101"
},
{
"path": "src-tauri/src/tally/runtime_control.rs",
Expand Down Expand Up @@ -958,5 +958,5 @@
"sha256": "a8ac2714fecf51947f2822c8c46d7ce2e8602c732780ff60566a7771f0836f9a"
}
],
"manifest_sha256": "368223b42559082724513067a7133a94fa4983fdb110ecb18fb57c45b44d51b3"
"manifest_sha256": "d1f7d3d265c7bda1f97b03db15220fd8de9d195cfd7cf34c0466e879cd580db6"
}
6 changes: 4 additions & 2 deletions scripts/outstandings-evidence.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ import { reportEvidenceDrawerEntry } from "../src/evidence-drawer-entry.ts";
import { readProvenance } from "../src/outstandings-provenance.ts";

test("native provenance labels its receivable-only count while native rows include both directions", async () => {
const [screen, panel, runtime] = await Promise.all([
const [screen, panel, runtime, runtimeTests] = await Promise.all([
readFile(new URL("../src/OutstandingsScreen.tsx", import.meta.url), "utf8"),
readFile(new URL("../src/OutstandingsEvidencePanel.tsx", import.meta.url), "utf8"),
readFile(new URL("../src-tauri/src/tally/runtime.rs", import.meta.url), "utf8"),
// The runtime's unit tests live beside it, not inline.
readFile(new URL("../src-tauri/src/tally/runtime_tests.rs", import.meta.url), "utf8"),
]);

assert.equal(readProvenance({ read_strategy: "native_bills", source_voucher_count: 0, open_receivable_bill_count: 1 }), "1 open receivable bill read from Tally");
Expand All @@ -28,7 +30,7 @@ test("native provenance labels its receivable-only count while native rows inclu
/all_open_bill_rows\(\s*&receivable_rows,\s*&payable_rows,\s*ageing_anchor,\s*&as_of,?\s*\)/.test(runtime),
"native statement rows must consume both receivable and payable sources",
);
assert.match(runtime, /assert_eq!\(statement_open_bills\.len\(\), 6\);/);
assert.match(runtimeTests, /assert_eq!\(statement_open_bills\.len\(\), 6\);/);
assert.match(panel, /readProvenance\(evidence\.readProvenance\)/);
assert.doesNotMatch(panel, /sourceVoucherCount/);
});
Expand Down
Loading