Bring the decomposition guide in line with #416 and #434 - #437
Merged
Merged
Conversation
The guide's worked example was the gap #434 closed: it listed seven unpinned collaborators of agent_import.rs, five of which are now pinned. It said "218 of 218", which #434 made 232, and that there is no capacity "by design" -- not what the history shows. RESERVED_SURFACE_FILES was introduced in #223 with the cap at exactly count + 15; exact-count raises are a convention since #260. In the slack period #246 added eight pins without touching the cap, which is what the convention now prevents. Its first rule, "Splitting a pinned file means pinning every file it splits into", contradicts the #416 decision to report rather than require: pin the parts that decide what Bridge posts or lets leave the machine, each with a named reason. It now names the two production collaborators still unpinned and why. One, agent_desktop_journal_review.rs, was missed by the #416 measurement itself -- declared `pub(crate) mod`, which the regex behind that measurement did not match -- and is recorded here as orchestration that delegates review, post and reconcile to the pinned agent_desktop_journal.rs. Documentation only. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
… cannot widen Fact-check found two sentences broader than the history. Exact-count raises date from #260, but a named reason beside the constant only from #278 (210 to 211); #260, #271 and #276 changed the number alone, and most of the 232 pins have no individual reason. And agent_import_schema.rs does run as build_import_xml's argument check, so it is described as what it is -- one that cannot widen admission, since agent_import.rs re-checks the bounds -- rather than as not deciding admission at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
#438 raises the cap to 238; the number belongs to the constant, not the prose. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation only. Brings
docs/module-decomposition.mdin line with #416's decisions and #434's merge.agent_import.rs; Seal the admission and egress files by name #434 pinned five. It now describes what was sealed, and names the two production collaborators still unpinned, with why:agent_import_schema.rs(publishes the contract rather than deciding admission) andagent_desktop_journal_review.rs(file picker, 5 MB cap, refusal messages; delegates review/post/reconcile to the pinnedagent_desktop_journal.rs).RESERVED_SURFACE_FILESarrived in chore: seal accounting compatibility surface #223 with the cap at exactly count + 15; exact-count raises are a convention since feat(desktop): remember checked endpoint hint #260. In the slack period feat(tally): expose native Trial Balance through MCP #246 added eight pins without touching the cap.The reseal report (#436) is deliberately not described here, since it hasn't merged; that PR will add the pointer.
One thing this surfaced:
agent_desktop_journal_review.rswas missed by the #416 measurement itself. It is declaredpub(crate) mod, which the regex behind that measurement didn't match — the same reasonagent_import_ledger.rswas missed until #434's review. Corrected on #416.🤖 Generated with Claude Code