refactor(p2p): move node name registry into P2PServer

[conache]

🗒️ Description / Motivation

The PeerId -> node_name lookup lived in a global RwLock<HashMap<PeerId, &'static str>> populated once at startup. This PR moves it into P2PServer so the actor owns its own state.

What Changed

• crates/net/p2p/src/lib.rs: the registry is now a field on the P2P actor's state struct, with a small helper to resolve a peer's name.
• crates/net/p2p/src/metrics.rs: no longer owns the registry — its peer-event helpers take the resolved name directly.
• bin/ethlambda/src/main.rs: the loader now returns the map and hands it off to P2P::spawn at startup; it also logs how many entries it loaded.

Correctness / Behavior Guarantees

• Metric label values (lean_connected_peers{client="..."}) are unchanged for valid configs.
• Bad rows in validator-config.yaml (unparseable secp256k1 privkeys) used to be silently dropped; they now emit a warn! per drop and are still skipped. No new panics, no new failure paths.
• No consensus-layer impact (fork choice, attestations, STF, signatures untouched).

Tests Added / Run

• make fmt
• make lint
• make test

Related Issues / PRs

• Closes Move node name registry to each module #106

[greptile-apps]

Greptile Summary

This PR refactors the PeerId → node_name lookup out of a global RwLock<HashMap<PeerId, &'static str>> in metrics.rs and into a node_names: HashMap<PeerId, String> field on P2PServer, eliminating a startup-time memory leak (String::leak()) and global mutable state. The metrics helpers are simplified to accept a pre-resolved &str, and invalid key entries now emit a warn! instead of being silently dropped.

Confidence Score: 5/5

Safe to merge — pure refactor with no behavioral changes to metrics labels, connection logic, or consensus paths.

No P0 or P1 issues found. The refactor correctly balances gauge increments/decrements across all connection event paths. The memory leak via String::leak() is eliminated, global mutable state is removed, and the actor now owns all its state. Metric label values are unchanged for valid configs.

No files require special attention.

Important Files Changed

Filename	Overview
crates/net/p2p/src/lib.rs	Moves node-name registry into P2PServer state; adds resolve_node_name helper and public derive_peer_ids function; re-exports PeerId instead of populate_name_registry.
crates/net/p2p/src/metrics.rs	Removes global RwLock registry, leaked &'static str storage, and PeerId-resolving logic; metrics helpers now accept pre-resolved node_name &str directly.
bin/ethlambda/src/main.rs	load_node_names replaces populate_name_registry, returns HashMap<PeerId, String> which is passed to P2P::spawn; adds info! log with loaded count.

Sequence Diagram

sequenceDiagram
    participant main as main.rs
    participant p2p as ethlambda_p2p
    participant server as P2PServer
    participant metrics as metrics.rs

    main->>p2p: derive_peer_ids(names_and_privkeys)
    p2p-->>main: HashMap<PeerId, String>
    main->>p2p: P2P::spawn(built, store, node_names)
    p2p->>server: construct P2PServer { node_names, ... }

    Note over server: SwarmEvent::ConnectionEstablished
    server->>server: resolve_node_name(Some(&peer_id)) → &str
    server->>metrics: notify_peer_connected(node_name, direction, "success")
    metrics->>metrics: LEAN_CONNECTED_PEERS[node_name].inc()

    Note over server: SwarmEvent::ConnectionClosed
    server->>server: resolve_node_name(Some(&peer_id)) → &str
    server->>metrics: notify_peer_disconnected(node_name, direction, reason)
    metrics->>metrics: LEAN_CONNECTED_PEERS[node_name].dec()

Loading

_{Reviews (1): Last reviewed commit: "Fix function doc comment" | Re-trigger Greptile}

[pablodeymo]

@conache can you please solve the conflicts?

[pablodeymo]

Request solve the conflicts

[conache]

@conache can you please solve the conflicts?

@pablodeymo thanks for the heads-up! sure, just solved the conflicts!