Conversation
Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 3.0.1 to 5.0.0. - [Release notes](https://github.com/actions/upload-pages-artifact/releases) - [Commits](actions/upload-pages-artifact@56afc60...fc324d3) --- updated-dependencies: - dependency-name: actions/upload-pages-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
gaochangw
left a comment
gaochangw
left a comment
There was a problem hiding this comment.
Reviewed head: bd86a3c
Found and fixed an artifact-content regression: the v4/v5 upload action excludes dotfiles by default, whereas our build deliberately creates site/.nojekyll. Added include-hidden-files: true for the generated site directory so the marker remains in the deployment artifact. The action still unconditionally excludes .git and .github.
Verified the action pin matches the signed upstream v5.0.0 release. Its nested upload-artifact v7 remains commit-pinned and defaults to archived uploads, preserving the github-pages artifact contract. Existing artifact naming, path, retention, and deployment permissions remain compatible.
Validation: ran the actual upstream Linux archive command locally with the configured input; index.html and .nojekyll are retained while .git and .github are excluded. Workflow YAML/input validation and git diff --check passed. The previous PR head passed the full CI matrix; the corrected head is running fresh CI and an explicit documentation artifact-upload workflow. Merge is contingent on those checks passing.
Upstream references: https://github.com/actions/upload-pages-artifact/releases/tag/v4.0.0 and https://github.com/actions/upload-pages-artifact/releases/tag/v5.0.0
This is an automated code review recorded through the repository administrator account, not an independent human approval.
1 participant
Bumps actions/upload-pages-artifact from 3.0.1 to 5.0.0.
Release notes
Sourced from actions/upload-pages-artifact's releases.
Commits
fc324d3Merge pull request #139 from Tom-van-Woudenberg/patch-1fe9d4b7Merge branch 'main' into patch-10ca1617Merge pull request #137 from jonchurch/include-hidden-files57f0e84Update action.yml4a90348v7 --> hash56f665aUpdate upload-artifact action to version 7f7615f5Addinclude-hidden-filesinput7b1f4a7Merge pull request #127 from heavymachinery/pin-sha4cc19c7Pinactions/upload-artifactto SHA2d163beMerge pull request #107 from KittyChiu/mainDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)