Testing#4
Draft
l0lawrence wants to merge 18 commits into
Draft
Conversation
🐍 Python emitter — generated test diff195 files changed · 👇 This PR changes generated output — update the baselineReview the rendered diff above. If the changes are expected, refresh the cd packages/http-client-python
npm run regenerate # produce fresh generated output
npm run regenerate:push-assets # publish baseline + bump assets.jsonThen commit the updated |
# Conflicts: # packages/http-client-python/eng/scripts/ci/regenerate-common.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
git diff --no-index prefixes each path with baseline/ vs current/, so
diff2html mistook every file for a rename ({baseline -> current}). Strip
those temp-dir prefixes from the per-file chunk header so old == new path
and it renders as a normal modification.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a --open flag that prints a clickable file:// URL and opens the rendered diff in the default browser, plus two npm scripts: - regenerate:diff render the diff and open it - regenerate:review regenerate then render+open so contributors get the same grouped HTML diff locally, no PR/CI needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
tests/**/generated is git-ignored, so the regenerated output never shows in VS Code Source Control. Add a --vscode mode that restores the assets-tag baseline, persists both normalized trees to temp/diff-trees, and opens a native 'code --diff' editor per changed file (capped via --max). New regenerate:vscode-diff script. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Extract the Python-specific regen-diff baseline + HTML-diff PR-preview system into a self-contained, language-agnostic tool under eng/common/scripts/regen-diff (render + push-assets CLI driven by a per-package regen-diff.config.json). Convert the Python emitter to use it as the reference adopter and generalize the publish/cleanup workflows so a single pair serves every emitter language (slug-namespaced gh-pages previews, sticky comment, and regen-diff/<slug> commit status). Adds an onboarding README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace the diff2html dependency with a small built-in renderer that emits a line-numbered, colorized unified diff per file, so the shared tool has no runtime rendering dependency (only picocolors remains). Rename the emitted stylesheet diff2html.css -> styles.css and update the publish allowlist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.