Repository navigation
Prove assumeIsolated(onQueue:) ordering under the production executor too (#51) - #60
Merged
Merged
Conversation
… too (#51) Recorder bound to SerialQueueExecutor directly, so the ordering test only proved that delegate-style callbacks interleave in order with actor calls under the 16-tier executor. Recorder now binds through QueueExecutor like Central and PeripheralHost (forced to the 16-tier executor by default, so the other tests are unchanged), and ordering runs under both selections, including DispatchSerialQueue's own executor on the 17 tier and later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recorder bound to SerialQueueExecutor directly, so the ordering test only
proved that delegate-style callbacks interleave in order with actor calls
under the 16-tier executor. Recorder now binds through QueueExecutor like
Central and PeripheralHost (forced to the 16-tier executor by default, so
the other tests are unchanged), and ordering runs under both selections,
including DispatchSerialQueue's own executor on the 17 tier and later.
Testing
The
orderingtest is parameterized over[true, false], and both cases run and pass.Closes #51