Skip to content

fix: merge config file for eBPF subcommands - #322

Merged
kxxt merged 1 commit into
mainfrom
ebpf-config
Sep 6, 2026
Merged

kxxt merged 1 commit into
mainfrom
ebpf-config

Conversation

@kxxt

@kxxt kxxt commented Sep 6, 2026

Copy link
Copy Markdown
Owner

No description provided.

@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tracexec Ready Ready Preview Sep 6, 2026 1:47am UTC

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 20 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Team

Run ID: 98c0d520-d41b-44b7-81ad-5ad036d7da05

📥 Commits

Reviewing files that changed from the base of the PR and between 8b9b538 and 62e9d40.

📒 Files selected for processing (1)
  • crates/tracexec-core/src/cli.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 6, 2026

Copy link
Copy Markdown

Greptile Summary

This PR enables configuration-file merging for all eBPF subcommands while preserving explicit CLI argument precedence.

  • Assigns the Clap parser the public command name tracexec.
  • Applies modifier and mode-specific configuration to eBPF log and TUI commands.
  • Applies configured foreground behavior and modifier options to eBPF collect.
  • Adds focused tests covering configuration merging and CLI overrides.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The new eBPF merge paths use the existing mode-specific merge implementations, preserve explicit CLI overrides, and correctly translate configured collect foreground state into the mutually exclusive flags consumed at runtime.

Important Files Changed

Filename Overview
crates/tracexec-core/src/cli.rs Adds eBPF configuration merging with consistent CLI precedence and comprehensive coverage across log, TUI, and collect modes.

Reviews (1): Last reviewed commit: "fix: merge config file for eBPF subcomma..." | Re-trigger Greptile

@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.13889% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.52%. Comparing base (fc84e6b) to head (62e9d40).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/tracexec-core/src/cli.rs 95.13% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #322      +/-   ##
==========================================
+ Coverage   82.47%   82.52%   +0.05%     
==========================================
  Files          84       84              
  Lines       21393    21536     +143     
==========================================
+ Hits        17644    17773     +129     
- Misses       3749     3763      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kxxt
kxxt merged commit 1b8fd6d into main Sep 6, 2026
27 checks passed
@kxxt
kxxt deleted the ebpf-config branch September 6, 2026 02:15

This branch was successfully deployed

1 active deployment
Preview — 62e9d404 Deployed Sep 6, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant