-
Notifications
You must be signed in to change notification settings - Fork 8
docs: add more documentation #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b248613
2baf75b
4d2f84c
e40ec0b
30b5e72
36a787f
ab06e53
caf3003
b062b09
0aafa92
ff56162
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||
| # Guidelines for Agents | ||||||
|
|
||||||
| ## Requirement | ||||||
|
|
||||||
| - If the user asks you to create a pull request, please include a file named `.agent-created-pr` in it. | ||||||
| - Make sure `cargo clippy --workspace` and `cargo +nightly fmt --all --check` check pass. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Match the documented checks to CI. The commands do not match Based on learnings: repository validation includes workspace Clippy and nightly rustfmt checks. Proposed wording-- Make sure `cargo clippy --workspace` and `cargo +nightly fmt --all --check` check pass.
+- Make sure `cargo clippy --workspace --all-targets -- -D warnings` and `cargo +nightly fmt --all -- --check` pass.📝 Committable suggestion
Suggested change
🤖 Prompt for AI AgentsSource: Learnings |
||||||
| - `README.md` should be updated through `README.template.md` and `just update-readme`. | ||||||
|
|
||||||
| ## Development Guideline | ||||||
|
|
||||||
| - Use rust idioms. | ||||||
| - Minimize `unwrap` and `expect` usage. | ||||||
| - Avoid `unsafe` code unless necessary. | ||||||
| - Do ablation study on your diffs. Drop unnecessary changes but never remove security related checks to make the diff look smaller. | ||||||
| - Add tests that really matters. | ||||||
| - Document invariants that are **not obvious** in comments. | ||||||
| - Do not use the docs as your daybook. | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Clarify who may create pull requests.
AGENTS.mdtells an agent to create a pull request when asked and add.agent-created-pr, butCONTRIBUTING.mdsays pull requests should be created by humans instead of AI agents. State whether the agent may create the pull request or may only prepare the branch and commits for a human.🤖 Prompt for AI Agents