fix: fake version for snapshot testing - #314
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
| Filename | Overview |
|---|---|
| crates/tracexec-tui/src/app/ui.rs | Selects a stable fake version under test configuration while preserving the Cargo package version in production builds. |
| crates/tracexec-tui/src/app.rs | Removes brittle snapshot-output replacement now that version stabilization occurs during rendering. |
| crates/tracexec-tui/src/snapshots/tracexec_tui__app__tests__snapshot_app_render.snap | Updates the default-theme snapshot to match direct rendering of the fixed test version. |
| crates/tracexec-tui/src/snapshots/tracexec_tui__app__tests__snapshot_app_render_with_custom_theme.snap | Updates the custom-theme snapshot to match direct rendering of the fixed test version. |
Reviews (1): Last reviewed commit: "fix: fake version for snapshot testing" | Re-trigger Greptile
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe TUI now uses a shared version constant for title rendering. Tests define a fake version at compile time, and snapshot tests no longer replace version text in rendered output. ChangesVersion Rendering
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Tests now use a fixed display version for stable snapshots while production continues to show the package version. The change is localized and introduces no actionable merge-blocking risk beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 82.52% 82.47% -0.06%
==========================================
Files 84 84
Lines 21399 21393 -6
==========================================
- Hits 17659 17643 -16
- Misses 3740 3750 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit