Skip to content

test: reuse canonical unstructured mesh assets - #4

Draft
kvnloo wants to merge 9 commits into
developfrom
test/shared-unstructured-mesh-assets
Draft

kvnloo wants to merge 9 commits into
developfrom
test/shared-unstructured-mesh-assets

Conversation

@kvnloo

@kvnloo kvnloo commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Promoted upstream

Canonical review path: openmc-dev#4152

This fork PR is open temporarily to validate the amended exact head. It will be closed again after fork CI passes.


Fork-only test-data cleanup following the shared-asset direction from openmc-dev#4093 and pshriwise's reference branch.

Scope

Point unit mesh/source/weight-window tests at the canonical unstructured-mesh files under tests/regression_tests/unstructured_mesh/ and remove four duplicate unit-level assets:

  • tests/unit_tests/test_mesh_tets.e
  • tests/unit_tests/test_mesh_hexes.exo
  • tests/unit_tests/test_mesh_dagmc_tets.vtk
  • tests/unit_tests/weightwindows/test_mesh_tets.exo

The DAGMC VTK unit copy was verified content-identical to the canonical regression VTK file before removal.

No production code changes and no test semantics intentionally change.

Boundary

The regression-suite .e / .exo files remain untouched; their blobs are not byte-identical, so this slice does not assume they are interchangeable.

Validation

Current exact head: 377be83af29831c0f74035deedcc57cfd6f43a38.
Fresh fork CI is the gate before treating the amended upstream PR as validated.

AI-assisted source review and implementation.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 36539116241

Coverage increased (+0.005%) to 81.39%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 72325
Covered Lines: 62563
Line Coverage: 86.5%
Relevant Branches: 29211
Covered Branches: 20077
Branch Coverage: 68.73%
Branches in Coverage %: Yes
Coverage Strength: 42759067.96 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants