Tuning Map - #183
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
+ Coverage 81.86% 81.89% +0.03%
==========================================
Files 807 809 +2
Lines 84613 84867 +254
==========================================
+ Hits 69267 69504 +237
- Misses 15346 15363 +17
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
TuningMapclass to the audio MIDI module, enabling flexible mapping of MIDI note numbers to frequencies using arbitrary scales and key maps, with support for loading Scala.scland.kbmfiles. The change also integrates this new class into the audio basics module and its test suite.New MIDI Tuning Features:
TuningMapclass (midi/yup_TuningMap.h), which allows mapping MIDI notes to frequencies under custom scales and key maps, with methods for loading Scala.scland.kbmfiles, querying note activity, and ensuring thread-safe, atomic updates. [1] [2]Integration and Build Updates:
yup_TuningMap.hheader in the main audio basics header (yup_audio_basics.h) and implementation file (yup_audio_basics.cpp), making the class available throughout the module. [1] [2]yup_TuningMap.cppimplementation to the test suite build (tests/yup_audio_basics.cpp) to facilitate unit testing of the new functionality.