Skip to content

Tuning Map - #183

Merged
kunitoki merged 3 commits into
mainfrom
dev/tuning_map
Sep 8, 2026
Merged

Tuning Map#183
kunitoki merged 3 commits into
mainfrom
dev/tuning_map

Conversation

@kunitoki

@kunitoki kunitoki commented Sep 8, 2026

Copy link
Copy Markdown
Owner

This pull request introduces a new TuningMap class to the audio MIDI module, enabling flexible mapping of MIDI note numbers to frequencies using arbitrary scales and key maps, with support for loading Scala .scl and .kbm files. The change also integrates this new class into the audio basics module and its test suite.

New MIDI Tuning Features:

  • Added the TuningMap class (midi/yup_TuningMap.h), which allows mapping MIDI notes to frequencies under custom scales and key maps, with methods for loading Scala .scl and .kbm files, querying note activity, and ensuring thread-safe, atomic updates. [1] [2]

Integration and Build Updates:

  • Included the new yup_TuningMap.h header in the main audio basics header (yup_audio_basics.h) and implementation file (yup_audio_basics.cpp), making the class available throughout the module. [1] [2]
  • Added the yup_TuningMap.cpp implementation to the test suite build (tests/yup_audio_basics.cpp) to facilitate unit testing of the new functionality.

@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.76378% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.89%. Comparing base (6389f3b) to head (76d0be4).

Files with missing lines Patch % Lines
modules/yup_audio_basics/midi/yup_TuningMap.cpp 90.07% 25 Missing ⚠️
modules/yup_audio_basics/midi/yup_TuningMap.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
+ Coverage   81.86%   81.89%   +0.03%     
==========================================
  Files         807      809       +2     
  Lines       84613    84867     +254     
==========================================
+ Hits        69267    69504     +237     
- Misses      15346    15363      +17     
Files with missing lines Coverage Δ
modules/yup_audio_basics/midi/yup_TuningMap.h 50.00% <50.00%> (ø)
modules/yup_audio_basics/midi/yup_TuningMap.cpp 90.07% <90.07%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6389f3b...76d0be4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki
kunitoki merged commit 69af3ee into main Sep 8, 2026
41 checks passed
@kunitoki
kunitoki deleted the dev/tuning_map branch September 8, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant