fix(bin): make inbox queueing portable to BSD sed

[kunchenguid]

Intent

Fix the macOS/BSD sed portability defect so the firstmate test suite runs clean locally on macOS. Reproduce the affected fm-voice-relay and fm-tool-update-check failures on macOS, identify the initiating BSD sed incompatibility separately from test symptoms, and make one portable behavior-preserving fix without an OS-specific branch. Keep the fix completely isolated from the forked-supervision Pi implementation, do not weaken assertions, and verify both affected suites on macOS and Linux where feasible. Deliver mode=no-mistakes with one PR, do not merge, and wait for CI green.

What Changed

• Generate inbox note IDs before writing staging files, removing the non-portable in-place sed rewrite while preserving atomic publication.
• Normalize whitespace in line-count assertions across the tool-update and voice-relay test suites for BSD/macOS wc output.

Risk Assessment

✅ Low: The change is narrowly scoped, removes the BSD-incompatible in-place sed call while preserving atomic note publication, and normalizes BSD wc output without weakening assertions.

Testing

On macOS 26.5.2, the base commit reproduced the initiating BSD sed error and both affected suite failures; the fixed commit passed both targeted suites and an end-to-end inbox queue operation produced one atomic note with matching record/filename IDs and exactly one wake. Linux execution was not feasible because no container runtime was available, and the worktree remained clean.

Evidence: macOS baseline reproduction showing the BSD sed incompatibility and both resulting suite failures

Source: macOS baseline reproduction showing the BSD sed incompatibility and both resulting suite failures

macOS/BSD baseline reproduction
platform: macOS 26.5.2

[base fm-inbox note] exit=1
sed: 1: "/var/folders/0k/bf8mwt2 ...": invalid command code f

[base fm-tool-update-check suite] exit=1
not ok - the report must be exactly one line for the wake record

[base fm-voice-relay suite] exit=1
ok - one deny decision per item covers every list that item could appear in
ok - the state verb is a closed vocabulary, so free text cannot ride out on it
ok - the backlog and the state directory always come from the same home
ok - a finished task's pull request is neither counted nor named
ok - a deny substring on an open title removes its pull request and says so
ok - an unknown read scope refuses instead of widening
ok - the configured read scope is honoured
not ok - fixture should start with an empty inbox

Evidence: macOS end-to-end inbox note publication and wake verification

Source: macOS end-to-end inbox note publication and wake verification

macOS end-to-end fm-inbox note verification
platform: macOS 26.5.2

$ FM_HOME=<temporary-home> bin/fm-inbox.sh note "Portable queue smoke test"
queued 1787480581-QzEAhy
  Portable queue smoke test
  firstmate will pick this up at its next check.

published note: state/inbox/1787480581-QzEAhy.note
record id matches filename: yes
record:
id=1787480581-QzEAhy
at=2026-08-23T10:23:01Z
source=text
--
Portable queue smoke test

wake records matching note id: 1

Pipeline

Updates from git push no-mistakes

✅ **intent** - passed

✅ No issues found.

✅ **Rebase** - passed

✅ No issues found.

✅ **Review** - passed

✅ No issues found.

✅ **Test** - passed

✅ No issues found.

• bash tests/fm-tool-update-check.test.sh
• bash tests/fm-voice-relay.test.sh
• Executed base-commit versions of fm-inbox.sh, fm-tool-update-check.test.sh, and fm-voice-relay.test.sh on macOS to reproduce the initiating BSD sed error and both suite symptoms
• FM_HOME=<temporary-home> bin/fm-inbox.sh note 'Portable queue smoke test' followed by verification of the published note ID, filename, body, and single wake record
• Checked for Docker/Podman availability for Linux verification; neither runtime was available
• git status --short to confirm transient baseline scripts and test data were removed

✅ **Document** - passed

✅ No issues found.

✅ **Lint** - passed

✅ No issues found.

✅ **Push** - passed

✅ No issues found.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The production refactor preserves note identity and atomic publication, while the test changes apply the repository’s established portable normalization pattern without changing asserted behavior.

_{Reviews (1): Last reviewed commit: "fix: make macOS inbox test path portable" | Re-trigger Greptile}