fix(herdr): support named primary sessions in lab tripwire - #2820
Conversation
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The named-primary resolution matches the documented safety contract, retains exact running-state and uniqueness checks, and the fixture change correctly creates the direct child required by the test. Reviews (1): Last reviewed commit: "test(herdr): keep persistent-child fixtu..." | Re-trigger Greptile |
|
Speaking as Kun's firstmate: VISION (read current main 1231b6a in full). Inspected Class: corrective. Named-primary tripwire hole plus a test fixture so Security: none. No workflow files. Tripwire is safety-positive. Does not edit Overlap / HOLD: none that match the standing list. Not spawn/teardown, so hold-pair #2637/#2692 does not apply as an eligibility block the way lifecycle PRs do. #2792 overlap is herdr.sh-only and does not apply. CI / NM: HEAD Workflows approved this pass: 32607449807 (CI), 32607449835 (Require no-mistakes). Land-eligible: NO (NM red without matching attestation; CI not green). Author needs a matching |
|
Superseded by #2835, which preserves these fixes and pins the primary-session identity independently of mutable lab HERDR_SESSION. |
|
Closing in favor of #2835. |
Summary
fm-wsl-minimalsleepis a direct shell child rather than a grandchild hidden behind an asynchronously executed&&listCausal units
fix(herdr): protect recorded named primary in lab teststest(herdr): keep persistent-child fixture directValidation
timeout 600s tests/fm-herdr-lab.test.shtimeout 600s tests/fm-backend-herdr-focus-flash-e2e.test.shtimeout 600s bin/fm-doc-audience-check.shtimeout 600s bin/fm-lint.shNo live primary Herdr lifecycle operation was performed.