test: repair remote and update-check fixture assumptions - #2819
Closed
Ikha14 wants to merge 3 commits into
Closed
Conversation
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The changes are confined to test fixtures and preserve their intended assertions while accommodating optional downstream dependencies, process subreapers, and whole-second budget boundaries. Reviews (1): Last reviewed commit: "test(tool-update): stabilize exhausted a..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair three independent test-fixture assumptions exposed by full-suite run
01M0NK3HAGHN2HB06QXHCQN75H:fm-ps-lib.shdependency into the remote handoff fixture when a downstream port provides it, preventing the copied wake library from failing before the confined-put assertion;The documentation failure was not a canonical documentation defect: the failing workspace contained unrelated
.paul/*.mdfiles from a divergent downstream default branch, while the tested branch and canonical inventory contain none of those files. No documentation text or inventory assertion was loosened.Diagnosis
fm-ps-lib.sh; masking condition: the fixture copied only the older dependency set; symptom: the superseded-payload comparison ran after fixture initialization had already failed.Validation
All commands were bounded by
timeout 600s.bash tests/fm-remote-backlog-handoff.test.sh- passedbash tests/fm-remote-job-orphan-reap.test.sh- passedbash tests/fm-documentation-audiences.test.sh- passedbash tests/fm-tool-update-check.test.sh- passed, including three consecutive supporting runs during diagnosisbin/fm-lint.sh- ShellCheck 0.11.0 and actionlint 1.7.12 passedbin/fm-doc-audience-check.sh- passed with 73 surfaces and 266 local linksgit diff --check upstream/main...HEAD- passed