fix: skip component_image_tags for components outside the kubescape-operator chart - #91
Merged
Merged
Conversation
…perator chart incluster-comp-pr-merged.yaml unconditionally appended client_payload[component_image_tags]=<COMPONENT_NAME>-tag=<tag> to every Helm E2E dispatch. That's only meaningful for the seven components the kubescape-operator chart actually has a "<name>-tag" value for (kubescape, operator, kubevuln, kollector, gateway, storage, nodeAgent). Consumers like http-request and prometheus-exporter aren't chart components, so their "-tag" override was silently dropped by armosec/system-tests until PR armosec/system-tests#1236 (merged 2026-08-31) added a fail-closed check for unrecognised "-tag" kwargs. Since then, every http-request/prometheus-exporter release has failed ks_microservice_on_demand with: unknown component image tag kwargs ['http-request-tag'] — expected one of ['gateway-tag', 'kollector-tag', 'kubescape-tag', 'kubevuln-tag', 'nodeAgent-tag', 'operator-tag', 'storage-tag'] blocking create-release-and-retag (see https://github.com/armosec/shared-workflows/actions/runs/33526635646/job/99921734558, triggered by kubescape/http-request#29). Now the override is only sent when COMPONENT_NAME is one of the chart's known components; the receiver already defaults component_image_tags to '' when absent (armosec/shared-workflows/.github/workflows/helm-e2e-receiver.yaml:60), so this is a no-op for the existing chart-component consumers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Summary:
|
1 similar comment
|
Summary:
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
incluster-comp-pr-merged.yamlunconditionally sentclient_payload[component_image_tags]=<COMPONENT_NAME>-tag=<tag>on every Helm E2E dispatch, even for components that aren't part of thekubescape-operatorchart (http-request,prometheus-exporter).armosec/system-tests#1236(merged 2026-08-31) started fail-closing on unrecognised*-tagoverrides, every release of those non-chart components now failsks_microservice_on_demandwithunknown component image tag kwargs ['http-request-tag'] — expected one of [...], which blockscreate-release-and-retag.component_image_tagswhenCOMPONENT_NAMEis one of the chart's known components (kubescape, operator, kubevuln, kollector, gateway, storage, nodeAgent).Root cause
Full trace: kubescape/http-request#29 merged →
incluster-comp-pr-merged.yamldispatchedcomponent_image_tags=http-request-tag=...toarmosec/shared-workflows→armosec/system-tests'stests_scripts/helm/base_helm.py:get_in_cluster_tags()rejects it as unknown (allowlist issystest_utils/statics.py:COMPONENT_TAGS, which has nohttp-requestentry —http-requestisn't inkubescape/helm-chartseither). Failing run: https://github.com/armosec/shared-workflows/actions/runs/33526635646/job/99921734558Before
armosec/system-tests#1236, the unrecognised kwarg was silently dropped (extract_tag_from_kwargs), so this was a latent no-op bug, not a failure.prometheus-exporterhas the identicalHELM_E2E_TEST: true+ non-chartCOMPONENT_NAMEsetup and is very likely broken the same way.Verified safe
armosec/shared-workflows/.github/workflows/helm-e2e-receiver.yaml:60already doesCOMPONENT_IMAGE_TAGS: ${{ github.event.client_payload.component_image_tags || '' }}— omitting the payload key entirely degrades to the same empty-string default it already handles. No change needed on the receiving side, and chart-component consumers (operator, kubevuln, storage, nodeAgent, ...) are unaffected.Test plan
python3 -c "import yaml; yaml.safe_load(...)")COMPONENT_NAMEis in the chart allowlist (e.g.storage) and confirmcomponent_image_tagsis still sent and its E2E test still passeskubescape/http-request's release (or dispatch manually) and confirmks_microservice_on_demandno longer fails withunknown component image tag kwargs🤖 Generated with Claude Code
AI-skills: armosec-shared-rules:investigate-system-test-failure