Skip to content

KEP-4222: Update beta requirements and target for 1.37.#6044

Open
benluddy wants to merge 3 commits intokubernetes:masterfrom
benluddy:4222-release-1.37
Open

KEP-4222: Update beta requirements and target for 1.37.#6044
benluddy wants to merge 3 commits intokubernetes:masterfrom
benluddy:4222-release-1.37

Conversation

@benluddy
Copy link
Copy Markdown
Contributor

  • One-line PR description: Adding found beta requirements and updating beta target to 1.37.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: benluddy
Once this PR has been reviewed and has the lgtm label, please assign sttts for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from apelisse April 29, 2026 16:30
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Apr 29, 2026
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz April 29, 2026 16:30
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 29, 2026
custom CBOR behaviors.
- All Kubernetes components have opted out of automatic transcoding to JSON for FieldsV1 and
RawExtension.
- Collection (i.e. List) object encoding supports "true" streaming (i.e. buffer size is not
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this is essential

RawExtension.
- Collection (i.e. List) object encoding supports "true" streaming (i.e. buffer size is not
proportional to output size).
- Structured endpoints like discovery, statusz, flagz, etc., support CBOR.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just hit a CBOR issue today I wanted to mention.

For the field GroupPriorityMinimum in staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1/types.go I had added an entry to test/integration/etcd/data.gosomething like: "spec": {"group": "foo.com", "version": "as2", "groupPriorityMinimum":100, "versionPriority":10}`. This works fine for JSON but breaks for CBOR due to a float vs int issue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a problem in common ecosystem workflows? I'm imagining something like dynClient.Resource(...).Create(...) with a yaml.Unmarshal or json.Unmarshal of a type like APIService with int fields is going to end up with floats sent by the client and an error when CBOR is enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants