KEP-4222: Update beta requirements and target for 1.37.#6044
KEP-4222: Update beta requirements and target for 1.37.#6044benluddy wants to merge 3 commits intokubernetes:masterfrom
Conversation
benluddy
commented
Apr 29, 2026
- One-line PR description: Adding found beta requirements and updating beta target to 1.37.
- Issue link: CBOR Serializer #4222
- Other comments: Consolidates KEP-4222: Add streaming list encode requirement to CBOR KEP. #5459 and KEP-4222: Add requirement to support discovery, statusz, etc. #5740.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benluddy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| custom CBOR behaviors. | ||
| - All Kubernetes components have opted out of automatic transcoding to JSON for FieldsV1 and | ||
| RawExtension. | ||
| - Collection (i.e. List) object encoding supports "true" streaming (i.e. buffer size is not |
| RawExtension. | ||
| - Collection (i.e. List) object encoding supports "true" streaming (i.e. buffer size is not | ||
| proportional to output size). | ||
| - Structured endpoints like discovery, statusz, flagz, etc., support CBOR. |
There was a problem hiding this comment.
I just hit a CBOR issue today I wanted to mention.
For the field GroupPriorityMinimum in staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1/types.go I had added an entry to test/integration/etcd/data.gosomething like: "spec": {"group": "foo.com", "version": "as2", "groupPriorityMinimum":100, "versionPriority":10}`. This works fine for JSON but breaks for CBOR due to a float vs int issue.
There was a problem hiding this comment.
This might be a problem in common ecosystem workflows? I'm imagining something like dynClient.Resource(...).Create(...) with a yaml.Unmarshal or json.Unmarshal of a type like APIService with int fields is going to end up with floats sent by the client and an error when CBOR is enabled