fix(manila-csi-plugin): revert to setting cluster id from environment - #3157
fix(manila-csi-plugin): revert to setting cluster id from environment#31571602077 wants to merge 1 commit into
Conversation
… variable Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
|
Hi @1602077. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test thanks for flagging @1602077 |
|
/lgtm |
|
cc @kayrus |
What this PR does / why we need it:
https://github.com/kubernetes/cloud-provider-openstack/pull/3141/changes#diff-b7f52a172b36d41c221a2e0760bf071c34a1ed12b7eb99e34d1aedb8e5d128f1R65 reverted my change in #3152 because it was not rebased properly.
This reverts this change so that I can once again set the cluster ID argument by passing the information from a config map.
Which issue this PR fixes(if applicable):
fixes #3070
Special notes for reviewers:
Release note: