Skip to content

fix(manila-csi-plugin): revert to setting cluster id from environment - #3157

Open
1602077 wants to merge 1 commit into
kubernetes:masterfrom
1602077:fix/cluster-id-from-secret
Open

fix(manila-csi-plugin): revert to setting cluster id from environment#3157
1602077 wants to merge 1 commit into
kubernetes:masterfrom
1602077:fix/cluster-id-from-secret

Conversation

@1602077

@1602077 1602077 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

https://github.com/kubernetes/cloud-provider-openstack/pull/3141/changes#diff-b7f52a172b36d41c221a2e0760bf071c34a1ed12b7eb99e34d1aedb8e5d128f1R65 reverted my change in #3152 because it was not rebased properly.

This reverts this change so that I can once again set the cluster ID argument by passing the information from a config map.

Which issue this PR fixes(if applicable):
fixes #3070

Special notes for reviewers:

Release note:

NONE

… variable

Signed-off-by: Jack Charlie Munday <1602077@users.noreply.github.com>
@kubernetes-prow kubernetes-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @1602077. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 5, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stephenfin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gouthampacha

Copy link
Copy Markdown
Contributor

/ok-to-test

thanks for flagging @1602077

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2026
@gouthampacha

Copy link
Copy Markdown
Contributor

/lgtm

@gouthampacha

Copy link
Copy Markdown
Contributor

cc @kayrus

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cinder-csi-plugin, manila-csi-plugin]: Add support for loading cluster-id from secret / configmap

2 participants