Skip to content

update the caclio registry to capzcicommunity - #590

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
zylxjtu:master
Aug 24, 2026
Merged

update the caclio registry to capzcicommunity#590
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
zylxjtu:master

Conversation

@zylxjtu

@zylxjtu zylxjtu commented Aug 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This is to unblock the 1.37 release

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2026
@kubernetes-prow kubernetes-prow Bot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2026
@zylxjtu

zylxjtu commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

This is part of the PR: cb69bf3

@marosset

marosset commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/approve
/lgtm
/hold for CI

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2026
jrvaldes
jrvaldes approved these changes Aug 24, 2026
View reviewed changes

@jrvaldes jrvaldes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubernetes-prow

kubernetes-prow Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrvaldes, linliu-msft-git, marosset, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jrvaldes

jrvaldes commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This is part of the PR: cb69bf3

was this broader fix with the defender exclusions proposed in a prev PR?

@kubernetes-prow

kubernetes-prow Bot commented Aug 24, 2026

Copy link
Copy Markdown

@zylxjtu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-capz-windows-2025-extension 93ca1ec link false /test pull-e2e-capz-windows-2025-extension

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zylxjtu

zylxjtu commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-e2e-capz-windows-2025-extension

@marosset

marosset commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/hold cancel
The 2025 flavor made it past calico bring-up on the CP node so we can merged this

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit fd2f701 into kubernetes-sigs:master Aug 24, 2026
7 of 8 checks passed
@adilGhaffarDev

adilGhaffarDev commented Aug 24, 2026

Copy link
Copy Markdown
Member

do we need to backport it to fix this test: https://testgrid.k8s.io/sig-release-1.37-informing#capz-windows-1.37&exclude-non-failed-tests=

@zylxjtu zylxjtu mentioned this pull request Aug 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx
@marosset marosset Awaiting requested review from marosset
2 more reviewers
@jrvaldes jrvaldes jrvaldes approved these changes
@linliu-msft-git linliu-msft-git linliu-msft-git approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@marosset marosset

@jrvaldes jrvaldes

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zylxjtu @marosset @jrvaldes @adilGhaffarDev @linliu-msft-git