Skip to content

Dynamic set the AKS version for management cluster - #584

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
zylxjtu:master
Jul 23, 2026
Merged

Dynamic set the AKS version for management cluster#584
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:masterfrom
zylxjtu:master

Conversation

@zylxjtu

@zylxjtu zylxjtu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Hard-pinning the aks version (previously --kubernetes-version 1.33.5) for CAPZ management cluster breaks CI every time AKS retires an old minor version. Set MGMT_K8S_VERSION to pin explicitly, otherwise use the region's current default GA version, falling back to the highest available version.

@kubernetes-prow
kubernetes-prow Bot requested a review from claudiubelu July 23, 2026 17:10
@kubernetes-prow kubernetes-prow Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 23, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from marosset July 23, 2026 17:10
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2026

@marosset marosset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold for CI

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2026
@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2026
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset, zylxjtu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zylxjtu

zylxjtu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/test pull-e2e-capz-windows-2025-extension

@kubernetes-prow

Copy link
Copy Markdown

@zylxjtu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-e2e-capz-windows-2025-extension 6bc0dd3 link false /test pull-e2e-capz-windows-2025-extension

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zylxjtu

zylxjtu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

will need to check for the 2025 test failure, but it passed the manager cluster creating stage, so the fix did works, will check in anyway to unblock the main master test job failure

@zylxjtu

zylxjtu commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

/hold cancel

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 461a0fe into kubernetes-sigs:master Jul 23, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants