fix(plugin-react-query): only pass a query key argument when the factory accepts one - #806
Merged
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 01e08b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… key support for Vue and React plugins
xeoneux
force-pushed
the
ak/fix-react-query
branch
from
August 27, 2026 19:46
6ba0e47 to
44a6956
Compare
Contributor
Author
|
Fixes #805 |
stijnvanhulle
approved these changes
Aug 28, 2026
Contributor
|
@xeoneux thanks again for opening a github issue and already fixing it, enjoy your work. Going to merge this in and create a new release for react-query and vue-query plugins. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For operations that only take header parameters (e.g. auth or correlation headers like
X-Request-Id), the generated query key factory takes 0 parameters since transport headers are excluded from cache keys. However, the generated hook passedresolvedParamsto the factory, causingTS2554: Expected 0 arguments, but got 1.The signature and the call site derived their parameter expectations from different sets of request groups:
buildQueryKeyParams(signature)path,query,bodybuildResolvedRequestParams(call site)path,query,body,headersqueryKeyGroupOrderandhasQueryKeyParamsare now centralized in@internals/tanstack-queryand shared acrossplugin-react-queryandplugin-vue-query:queryOptionscontinues to receiveresolvedParamsso header parameters are still properly forwarded to the underlying client call.Generated output for a header-only operation:
const resolvedParams = { headers: typeof headers === 'function' ? headers() : headers } - const queryKey = resolvedOptions?.queryKey ?? retrieveMyProfileQueryKey(resolvedParams) + const queryKey = resolvedOptions?.queryKey ?? retrieveMyProfileQueryKey() const queryResult = useQuery({ ...retrieveMyProfileQueryOptions(resolvedParams, config), ...resolvedOptions, queryKey, } as unknown as QueryObserverOptions, queryClient)