fix(plugin-zod): keep an array default as an array literal - #804
Merged
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
🦋 Changeset detectedLatest commit: 8bc5aa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Fixes #803 |
…als in formatDefault
stijnvanhulle
approved these changes
Aug 28, 2026
Contributor
|
@all-contributors please add @xeoneux for code |
Contributor
|
I've put up a pull request to add @xeoneux! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the array case in
formatDefault, so adefault: []reached through a$refno longerbecomes
.default({}).formatDefaultbranched ontypeof value === 'object', which is also true for an array, so[]took the object path and returned
'{}'.defaultLiteralonly guarded this for nodes that narrowto
array, and a property referencing an array schema is a ref node, so it fell through andproduced
z.array(...).default({})— a schema that does not typecheck (TS2769).Arrays are now handled before the object case:
Before / after for a property referencing an array schema:
The fix is in
formatDefaultrather thandefaultLiteralso it also covers any other path thatreaches the value without a narrowed array node. Plain objects still collapse to
{}, unchanged.