Clamp GetCommandsInRange against the remaining commands so a large count cannot overflow [patch] - #106
Merged
Conversation
…unt cannot overflow [patch] GetCommandsInRange(1, int.MaxValue) summed startIndex + count, which wrapped negative and made List.GetRange throw. Compare count against the commands remaining after startIndex instead. Fixes #105 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013xQ2dceFuWS8VLEn2xLuZE
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105
What changed
StackManager.GetCommandsInRangecomputedMath.Min(startIndex + count, _commands.Count). With a non-zero start andcount = int.MaxValue, the sum wrapped negative,Math.Minpicked it, andList<T>.GetRangethrewArgumentException. The method now comparescountagainst the commands remaining afterstartIndex, so the addition that overflowed is gone.Test
Added
GetCommandsInRange_CountOfIntMaxValueFromNonZeroStart_ReturnsRemainingCommands. It covers starts at 1 and 2 withint.MaxValue, plus an ordinary in-range count.ArgumentExceptionfromGetRangedescribed in the issue.🤖 Generated with Claude Code
https://claude.ai/code/session_013xQ2dceFuWS8VLEn2xLuZE
Generated by Claude Code