Rebuild a saved command whose SerializeData() returned an empty string - #103
Merged
Merged
Conversation
ConvertFromSerializableCommand treated an empty Data the same as a null one and loaded a PlaceholderCommand, so a parameterless ISerializableCommand came back un-undoable even though the load reported success. Only a null Data, which ConvertToSerializableCommand writes for commands that are not ISerializableCommand, now selects the placeholder. Fixes #92 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018fKEEvMM2dQpZfMjTCXhRL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
What was wrong
JsonUndoRedoSerializer.ConvertFromSerializableCommandfell back toPlaceholderCommandwheneverDatawas null or empty.ConvertToSerializableCommandonly uses null, and only for commands that are notISerializableCommand.""is a normalSerializeData()result for a command with no parameters, such as "Clear all". Such a command came back as a placeholder,LoadStateAsyncstill returnedtrue, and the firstUndo()threwNotSupportedException.Change
Data is null. An empty string goes through the normalActivator.CreateInstance+DeserializeData("")path, and inherits the error handling Report every unloadable saved command as a failed load #99 added to that path.Data!on theDeserializeDatacall is gone, because flow analysis now provesDatais non-null there.Tests
UndoRedoService_SaveLoadState_ReconstructsCommandWithEmptyDatasaves a parameterless command whoseSerializeData()returns""and loads it into a fresh service. It then checks that the command comes back as its real type and thatUndoAsync()succeeds.🤖 Generated with Claude Code
https://claude.ai/code/session_018fKEEvMM2dQpZfMjTCXhRL
Generated by Claude Code