Fold an inline (?i) culture-invariantly too [patch] - #121
Merged
matt-edmondson merged 1 commit intoSep 28, 2026
Merged
Conversation
CultureInvariant was only set for CaseInsensitive, so a CaseSensitive pattern that asked for its own fold with (?i) still folded by the current culture. Compiled under tr-TR, "(?i)img" stopped matching "IMG_1234.JPG", and the regex cache kept that compile for every later caller. Set CultureInvariant on every compiled filter. Fixes #120 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P1dENrzXtWG4vP7thSjyof
|
This was referenced Sep 27, 2026
matt-edmondson
deleted the
claude/textfilter-120-inline-ignorecase-culture
branch
September 28, 2026 01:34
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120
Problem
DoesMatchRegexsetRegexOptions.CultureInvariantonly forCaseInsensitive. ACaseSensitivefilter can still request a fold itself with an inline(?i), and that fold then used the thread's current culture. If(?i)imgwas compiled under tr-TR first, it stopped matchingIMG_1234.JPG, and because the regex cache is keyed by pattern and sensitivity only, every later caller got the same answer.Change
TextFilter/TextFilter.cs: every compiled filter now usesCompiled | CultureInvariant, andIgnoreCaseis added only forCaseInsensitive.TextFilter.Test/TextFilterTests.cs: addedAnInlineIgnoreCaseFoldsTheSameWhateverCultureCompiledIt. It compiles(?i)imgunder tr-TR first, then expects a match under both tr-TR and en-US.Verification
Assert.IsTrue(underTurkish).🤖 Generated with Claude Code
https://claude.ai/code/session_01P1dENrzXtWG4vP7thSjyof
Generated by Claude Code