Redesign chord symbols around a shared grammar - #362
Merged
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Comment on lines
+75
to
+82
| if (symbol.Length == chord.Root.Name.Length) | ||
| { | ||
| _ = symbol.Append('(').Append(alterations).Append(')'); | ||
| } | ||
| else | ||
| { | ||
| _ = symbol.Append(alterations); | ||
| } |
Copilot
AI
changed the title
[WIP] Redesign chord symbols for Chord.Parse and Chord.ToString
Redesign chord symbols around a shared grammar
Oct 1, 2026
matt-edmondson
marked this pull request as ready for review
October 2, 2026 03:53
|
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Chord parsing and formatting could disagree about token boundaries, implied tensions, and slash basses, causing symbols to change meaning on round-trip. Replace the substring parser and concatenated formatter with a grammar-driven reader and canonical writer.
MinorSharpFive, and update chord tones and roman-numeral analysis.C79,Csus47, andC6add9.