Skip to content

Add AUTHORS.md so every identity keeps the ktsu. prefix - #143

Merged
matt-edmondson merged 1 commit into
mainfrom
claude/add-authors-md
Sep 21, 2026
Merged

matt-edmondson merged 1 commit into
mainfrom
claude/add-authors-md

Conversation

@matt-edmondson

Copy link
Copy Markdown
Contributor

Fixes #116

What

ktsu.Sdk derives AuthorsNamespace from the first dotted segment of AUTHORS.md. This repo had no such file, so the value resolved empty and the ktsu. prefix was dropped silently from both the app and its test project.

  • Adds AUTHORS.md containing ktsu.dev contributors, matching the org majority
  • Moves the InternalsVisibleTo literal in ImageDescriber/Program.cs from ImageDescriber.Test to ktsu.ImageDescriber.Test in the same commit

The coupling the sibling issue warned about is present here too

The issue text for this repo doesn't mention InternalsVisibleTo, but ktsu-dev/FileDeduplicator#91's comment asked to check for it before fixing the siblings. It is here — in Program.cs rather than a Properties/AssemblyInfo.cs. Adding AUTHORS.md alone does not build:

error KTSU0002: Consider exposing internals to test project 'ktsu.ImageDescriber.Test'.
Add '[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("ktsu.ImageDescriber.Test")]' to a .cs file.

So the literal has to move with the file, exactly as in FileDeduplicator.

Verification

  • On main, the app builds as ImageDescriber.dll — the unprefixed name the issue reports
  • With this change it builds as ktsu.ImageDescriber.dll, and the test project as ktsu.ImageDescriber.Test
  • Clean rebuild of ImageDescriber.slnx: 0 errors, 0 warnings
  • Test suite: 37/37 passing, which is what exercises the restored internals access

No new test is added: the defect is in derived build identity, and the analyzer plus the assembly name are what assert it.

The source already declared namespace ktsu.ImageDescriber; explicitly, so only the assembly name and the derived root namespace were wrong — no source namespaces move.

Nothing was published under the unprefixed name: ktsu.Sdk marks only libraries and PackAsTool projects packable, and this is an Exe via ktsu.Sdk.ConsoleApp.

Siblings

Companion to ktsu-dev/FileDeduplicator#124, which fixes the identical gap there. ImageGui is the third repo missing the file and still needs the same treatment, including the same check for an InternalsVisibleTo literal in ImageGui.Core.Tests / ImageGui.App.UiTests.

Part of the naming audit tracked in ktsu-dev/Sdk#36.

🤖 Generated with Claude Code

https://claude.ai/code/session_01AEnne4CKU84fkH76m2eK2Y


Generated by Claude Code

ktsu.Sdk derives AuthorsNamespace from the first dotted segment of
AUTHORS.md. With no such file the value was empty and the prefix was
dropped silently, so this repo built as ImageDescriber, and its tests as
ImageDescriber.Test, where every other one in the org builds as
ktsu.<Name>.

Adds AUTHORS.md containing "ktsu.dev contributors", matching the 49
repos that already have it, and moves the InternalsVisibleTo literal in
Program.cs to ktsu.ImageDescriber.Test in the same commit. Without that
move ktsu.Sdk's KTSU0002 fails the build, which is what catches the test
project losing access to internals.

Sibling of ktsu-dev/FileDeduplicator#91, which carries the same gap and
the same coupling.

Nothing was published under the unprefixed name: ktsu.Sdk marks only
libraries and PackAsTool projects packable, and this is an Exe via
ktsu.Sdk.ConsoleApp.

Fixes #116

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AEnne4CKU84fkH76m2eK2Y

Copy link
Copy Markdown
Contributor Author

github-advanced-security is failing on an account quota, not on this PR

The only red check here is github-advanced-security. Its job log ends with:

Error creating PR review request: SessionModelError: You have exceeded your monthly quota
  errorType: 'quota', statusCode: 402
##[error]Process completed with exit code 1.

That is the Copilot autofix step exhausting a monthly account quota (HTTP 402) before it analyses anything. It is not a finding against this diff — which adds one text file and changes one string literal — and no change to this branch can clear it. It needs the quota topped up or that step made non-blocking. CodeQL, Analyze (csharp) and Analyze (actions) all pass; only the Copilot-backed job fails.

Everything else on this head is green: Test on ubuntu-latest, Test on macos-latest and Test on windows-latest all pass.

I have not spent a re-run on it. A 402 quota error is deterministic, and the cross-check a re-run would give is already in hand from a stronger source: the identical failure is on four PRs I opened today across four repositories with four unrelated diffs — ktsu-dev/KtsuTools#174, ktsu-dev/ThemeProvider#103, ktsu-dev/FileDeduplicator#124 and #143.

No fix exists to port, so there is nothing for me to push here. Flagging it because it is org-wide rather than specific to this PR, and it will keep every PR red until the quota is dealt with.


Generated by Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@matt-edmondson
matt-edmondson merged commit fc84b64 into main Sep 21, 2026
11 of 12 checks passed
@matt-edmondson
matt-edmondson deleted the claude/add-authors-md branch September 21, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing AUTHORS.md drops the ktsu. prefix from every identity

1 participant