Drop the unused new() constraint from GetOrCreate(key, defaultValue) - #140
Merged
Merged
Conversation
The IDictionary and ConcurrentDictionary overloads that take a default value insert the value the caller supplies and never construct one, but still required a parameterless constructor. Calls with a string, an interface or any type without one failed to compile with CS0310, which are exactly the cases the one-argument overload cannot serve either. Relaxing the constraint is source-compatible. The one-argument overloads keep new(), since they construct the value. Fixes #139 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LasidbyRZfyxgW8Z9wQu9M
|
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139
What changed
The
IDictionaryandConcurrentDictionaryoverloads ofGetOrCreate(key, defaultValue)inExtensions/DictionaryExtensions.csrequiredTVal : new(), but they never construct a value. As a result, calls with astring, an interface, or any type without a parameterless constructor failed to compile with CS0310.This PR removes
new()from both overloads.notnulland the runtime null checks stay. The one-argument overloads keepnew(), because they do construct the value. Relaxing a constraint is source-compatible for existing callers.Tests
stringvalue and anIList<int>value, onDictionaryand onConcurrentDictionary. Each checks that the value is inserted when missing, and that the existing value is returned on a later call.dotnet test Extensions.Testpasses 146/146.🤖 Generated with Claude Code
https://claude.ai/code/session_01LasidbyRZfyxgW8Z9wQu9M
Generated by Claude Code