Read .inf, -.inf and .nan back as double literals - #95
Merged
Merged
Conversation
The serializer writes infinite and NaN doubles with the YAML core schema's spellings, which double.TryParse does not accept, so the deserializer dropped the literal and a declaration initialised to infinity came back with no initialiser. The deserializer now reads every core-schema spelling of the non-finite values. Part of #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015cCJCbaqmqLWvEB1Pep4Q9
|
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #78. This covers the YAML half of what #90 left open. Per-language spellings of infinity and NaN are still to do, so the issue stays open.
What changed
YamlDotNet writes infinite and NaN doubles with the YAML core schema's spellings:
.inf,-.infand.nan.YamlDeserializerparsed double literals withdouble.TryParse, which doesn't accept those spellings. The literal was dropped, sodouble inf = +∞came back asdouble inf;with no initialiser.The
Doublecase now goes through a smallTryParseDoublehelper. It reads every core-schema spelling of the non-finite values (.inf/.Inf/.INF, with an optional+, then-.infand.nanin the same case variants) and falls back to the existing invariantdouble.TryParsefor everything else.Tests
NonFiniteDoubleSerializationTests:+∞,-∞andNaNliterals keeps the valueVariableDeclarationinitialised to infinity keeps its initialiser after a round tripWith the fix, 926/926 pass. With
YamlDeserializer.csreverted, all 13 new cases fail and the other 913 tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_015cCJCbaqmqLWvEB1Pep4Q9
Generated by Claude Code