Number Python and JavaScript enum members on from the previous value - #89
Merged
Merged
Conversation
…[patch] A member with no value of its own took its position, so after an explicit value the two languages disagreed with C, C++, Rust and Go and could repeat an earlier value, which Python turns into a silent alias. Fixes #79. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012B4b6sZaZ7tFJzNvax1B89
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79
What changed
LanguageGeneratorBase.EnumMemberValues. It gives each member without its own value the previous member's value plus one, the same numbering C, C++, Rust and Go use. When the previous value isn't a plain integer, such as1 << 4, the next member gets(1 << 4) + 1, then(1 << 4) + 2. Unlike a member name, that expression is valid in both a Python class body and a JS object literal.PythonGenerator.GenerateEnumDeclarationandJavaScriptGenerator.WriteEnumMembersnow use it instead ofmember.Value ?? index.TypeDeclarationTests:Red, Green = 5, BluegivesBlue = 6in Python and JS. Before this change it gave 2.Verification
dotnet build: clean, no analyzer errors. Full suite: 907/907 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_012B4b6sZaZ7tFJzNvax1B89
Generated by Claude Code